Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor metrics prompt functions and change color package name #5890

Merged
merged 3 commits into from
May 21, 2021

Conversation

MarlonGamez
Copy link
Contributor

Related: #5370
Description
Refactor to move pkg/skaffold/instrumentation/ prompt functions into pkg/skaffold/instrumentation/prompt/, and rename the color package to output. This package will be added upon in an upcoming PR

@MarlonGamez MarlonGamez requested a review from briandealwis May 21, 2021 17:29
@google-cla google-cla bot added the cla: yes label May 21, 2021
@MarlonGamez MarlonGamez changed the title Output refactor Refactor metrics prompt functions and change color package name May 21, 2021
@codecov
Copy link

codecov bot commented May 21, 2021

Codecov Report

Merging #5890 (0d1309a) into master (ff5038a) will not change coverage.
The diff coverage is 63.39%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #5890   +/-   ##
=======================================
  Coverage   70.91%   70.91%           
=======================================
  Files         447      447           
  Lines       16908    16908           
=======================================
  Hits        11990    11990           
  Misses       4028     4028           
  Partials      890      890           
Impacted Files Coverage Δ
cmd/skaffold/app/cmd/diagnose.go 64.51% <0.00%> (ø)
cmd/skaffold/app/cmd/find_configs.go 48.48% <0.00%> (ø)
cmd/skaffold/app/cmd/generate_pipeline.go 61.53% <0.00%> (ø)
cmd/skaffold/app/cmd/runner.go 58.49% <0.00%> (ø)
cmd/skaffold/skaffold.go 0.00% <0.00%> (ø)
pkg/skaffold/build/bazel/build.go 67.24% <0.00%> (ø)
pkg/skaffold/build/gcb/cloud_build.go 0.00% <0.00%> (ø)
pkg/skaffold/build/local/local.go 61.36% <0.00%> (ø)
pkg/skaffold/build/result.go 83.33% <0.00%> (ø)
pkg/skaffold/deploy/kubectl/kubectl.go 65.18% <0.00%> (ø)
... and 37 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ff5038a...0d1309a. Read the comment docs.

Copy link
Contributor

@aaron-prindle aaron-prindle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@MarlonGamez MarlonGamez merged commit efabcc0 into GoogleContainerTools:master May 21, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants