Pause debug pod watchers before next iteration deploy

[tejal29]

Fixes #5914

See #5914 (comment) for more details on why we need to stop the debug manager between deploys.

Changes in this PR

1. Add a Watcher Interface for PortforwardManager and DebugManager with Start and Stop methods.
2. Call Stop for DebugManager similar to what we do for PortforwardManager.
3. Remove close from DebugManager.Stop since the doc mention close should only be called by sender. Changed the DebugManager.Stop to stop the pod watchers.

Verified locally, we don't see an DebugContainerEvent in StatusCheck phase.

[google-cla]

All (the pull request submitter and all commit authors) CLAs are signed, but one or more commits were authored or co-authored by someone other than the pull request submitter.

We need to confirm that all authors are ok with their commits being contributed to this project. Please have them confirm that by leaving a comment that contains only @googlebot I consent. in this pull request.

Note to project maintainer: There may be cases where the author cannot leave a comment, or the comment is not properly detected as consent. In those cases, you can manually confirm consent of the commit author(s), and set the cla label to yes (if enabled on your project).

ℹ️ Googlers: Go here for more info.

[google-cla]

All (the pull request submitter and all commit authors) CLAs are signed, but one or more commits were authored or co-authored by someone other than the pull request submitter.

We need to confirm that all authors are ok with their commits being contributed to this project. Please have them confirm that by leaving a comment that contains only @googlebot I consent. in this pull request.

Note to project maintainer: There may be cases where the author cannot leave a comment, or the comment is not properly detected as consent. In those cases, you can manually confirm consent of the commit author(s), and set the cla label to yes (if enabled on your project).

ℹ️ Googlers: Go here for more info.

[tejal29]

@googlebot I fixed it

[google-cla]

All (the pull request submitter and all commit authors) CLAs are signed, but one or more commits were authored or co-authored by someone other than the pull request submitter.

We need to confirm that all authors are ok with their commits being contributed to this project. Please have them confirm that by leaving a comment that contains only @googlebot I consent. in this pull request.

Note to project maintainer: There may be cases where the author cannot leave a comment, or the comment is not properly detected as consent. In those cases, you can manually confirm consent of the commit author(s), and set the cla label to yes (if enabled on your project).

ℹ️ Googlers: Go here for more info.

[codecov]

Codecov Report

Merging #5932 (6a7abbc) into master (fafdcd7) will decrease coverage by 0.02%.
The diff coverage is 55.55%.

@@            Coverage Diff             @@
##           master    #5932      +/-   ##
==========================================
- Coverage   70.67%   70.65%   -0.03%     
==========================================
  Files         454      454              
  Lines       17395    17399       +4     
==========================================
- Hits        12294    12293       -1     
- Misses       4195     4197       +2     
- Partials      906      909       +3     

Impacted Files	Coverage Δ
...skaffold/kubernetes/debugging/container_manager.go	50.98% <33.33%> (+0.98%)	⬆️
pkg/skaffold/runner/v1/dev.go	73.11% <60.00%> (+0.12%)	⬆️
...affold/kubernetes/portforward/forwarder_manager.go	50.00% <100.00%> (+1.11%)	⬆️
pkg/skaffold/util/tar.go	50.66% <0.00%> (-5.34%)	⬇️
pkg/skaffold/docker/image.go	78.34% <0.00%> (-1.39%)	⬇️
pkg/skaffold/event/v2/event.go	74.03% <0.00%> (+0.12%)	⬆️
pkg/skaffold/docker/parse.go	87.14% <0.00%> (+0.95%)	⬆️

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update fafdcd7...6a7abbc. Read the comment docs.

[briandealwis]

You need to drop a7ce90d — sorry, it was a test :-(

[tejal29]

You need to drop a7ce90d — sorry, it was a test :-(

No worries.

[briandealwis]

I think one consequence of this change is that all debug sessions will be torn down and need to be re-established. I’m not sure CC-IJ does this at the moment — @etanshaul?

Maybe we need these managers to have a Pause() and Resume () that can be a bit more intelligent at resolving the impact of pod changes.

[etanshaul]

I’m not sure CC-IJ does this at the moment — @etanshaul?

IntelliJ has no iterative debugging at the moment (unless the user goes out of their way to turn on watching via env vars - but this isn't yet an officially supported path).

[briandealwis]

And CC-IJ doesn't reconnect on a dropped connection.