Emit status check subtask events for V2 API #5961
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tejal29
reviewed
Jun 7, 2021
Codecov Report
@@ Coverage Diff @@
## master #5961 +/- ##
==========================================
+ Coverage 70.57% 70.77% +0.20%
==========================================
Files 457 460 +3
Lines 17534 17706 +172
==========================================
+ Hits 12374 12531 +157
- Misses 4246 4251 +5
- Partials 914 924 +10
Continue to review full report at Codecov.
|
nkubala
reviewed
Jun 8, 2021
| TaskId: fmt.Sprintf("%s-%d", constants.StatusCheck, handler.iteration), | ||
| Resource: r, | ||
| Status: Failed, | ||
| StatusCode: ae.ErrCode, |
There was a problem hiding this comment.
we don't add a Message for failures? that's embedded in the actionable error then?
There was a problem hiding this comment.
mhm, I'm not 100% on the original intent as this is from v1, but I think it's basically that in the case of a non-failure, we still want a message, and in the case of a failure, we put the message in the actionable error
nkubala
approved these changes
Jun 8, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #5785
Related: #5368
Description
Event API V2 now emits
StatusCheckSubtaskEvents, which give information about resources being updated during their deployment to a cluster.Most of this functionality is taken from V1
User facing changes (remove if N/A)
Users will not see
StatusCheckSubtaskEventsemitted through the API.