Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change parsing templated image warning to debug info #6398

Merged

Conversation

azhao155
Copy link
Contributor

Change parsing templated image warning to debug info to reduce noise.

@azhao155 azhao155 requested a review from a team as a code owner August 10, 2021 07:53
@azhao155 azhao155 requested a review from MarlonGamez August 10, 2021 07:53
@google-cla google-cla bot added the cla: yes label Aug 10, 2021
@codecov
Copy link

codecov bot commented Aug 10, 2021

Codecov Report

Merging #6398 (c666079) into main (10f4672) will increase coverage by 0.01%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #6398      +/-   ##
==========================================
+ Coverage   70.36%   70.38%   +0.01%     
==========================================
  Files         499      499              
  Lines       22725    22725              
==========================================
+ Hits        15991    15994       +3     
+ Misses       5691     5688       -3     
  Partials     1043     1043              
Impacted Files Coverage Δ
pkg/skaffold/kubernetes/manifest/images.go 100.00% <100.00%> (ø)
pkg/skaffold/tag/util/util.go 92.30% <100.00%> (ø)
pkg/skaffold/docker/parse.go 87.39% <0.00%> (-0.85%) ⬇️
pkg/skaffold/util/tar.go 65.51% <0.00%> (+2.29%) ⬆️
pkg/skaffold/log/stream/stream.go 81.25% <0.00%> (+18.75%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 10f4672...c666079. Read the comment docs.

@tejal29
Copy link
Contributor

tejal29 commented Aug 10, 2021

@azhao155 Thank you for the fix. Please fix the lint error :)

@tejal29 tejal29 merged commit 638bec4 into GoogleContainerTools:main Aug 10, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants