Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Drop codecov threshold to 30% #6608

Merged
merged 1 commit into from
Sep 16, 2021
Merged

Conversation

nkubala
Copy link
Contributor

@nkubala nkubala commented Sep 15, 2021

No description provided.

@nkubala nkubala requested a review from a team as a code owner September 15, 2021 17:39
@nkubala nkubala requested a review from tejal29 September 15, 2021 17:39
@google-cla google-cla bot added the cla: yes label Sep 15, 2021
@codecov
Copy link

codecov bot commented Sep 15, 2021

Codecov Report

Merging #6608 (c1f5d7c) into main (290280e) will decrease coverage by 0.69%.
The diff coverage is 34.27%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #6608      +/-   ##
==========================================
- Coverage   70.48%   69.78%   -0.70%     
==========================================
  Files         515      520       +5     
  Lines       23150    23594     +444     
==========================================
+ Hits        16317    16466     +149     
- Misses       5776     6059     +283     
- Partials     1057     1069      +12     
Impacted Files Coverage Δ
cmd/skaffold/app/cmd/flags.go 89.00% <0.00%> (-1.82%) ⬇️
cmd/skaffold/skaffold.go 0.00% <ø> (ø)
pkg/skaffold/build/buildpacks/logger.go 0.00% <ø> (ø)
pkg/skaffold/build/cluster/logs.go 0.00% <ø> (-16.67%) ⬇️
pkg/skaffold/config/options.go 100.00% <ø> (ø)
pkg/skaffold/debug/apply_transforms.go 22.64% <0.00%> (-0.44%) ⬇️
pkg/skaffold/debug/transform.go 95.91% <ø> (ø)
.../skaffold/deploy/component/kubernetes/component.go 90.00% <0.00%> (-4.74%) ⬇️
pkg/skaffold/deploy/docker/deploy.go 0.00% <0.00%> (ø)
pkg/skaffold/docker/client.go 90.36% <ø> (ø)
... and 62 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1186c42...c1f5d7c. Read the comment docs.

@MarlonGamez MarlonGamez merged commit 8e2edf9 into GoogleContainerTools:main Sep 16, 2021
@nkubala nkubala deleted the codecov branch September 17, 2021 18:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants