Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: use new stringslice lib #6752

Merged
merged 1 commit into from
Oct 20, 2021

Conversation

aaron-prindle
Copy link
Contributor

No description provided.

@aaron-prindle aaron-prindle requested a review from a team as a code owner October 20, 2021 19:11
@google-cla google-cla bot added the cla: yes label Oct 20, 2021
@aaron-prindle aaron-prindle requested review from briandealwis and removed request for gsquared94 October 20, 2021 19:12
Copy link
Contributor

@MarlonGamez MarlonGamez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, conventional commits check fails though

@codecov
Copy link

codecov bot commented Oct 20, 2021

Codecov Report

Merging #6752 (0df3994) into main (290280e) will decrease coverage by 0.79%.
The diff coverage is 56.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #6752      +/-   ##
==========================================
- Coverage   70.48%   69.69%   -0.80%     
==========================================
  Files         515      535      +20     
  Lines       23150    24281    +1131     
==========================================
+ Hits        16317    16922     +605     
- Misses       5776     6246     +470     
- Partials     1057     1113      +56     
Impacted Files Coverage Δ
cmd/skaffold/app/cmd/flags.go 89.00% <0.00%> (-1.82%) ⬇️
cmd/skaffold/skaffold.go 0.00% <ø> (ø)
cmd/skaffold/app/cmd/lint.go 52.94% <52.94%> (ø)
cmd/skaffold/app/cmd/cmd.go 70.49% <75.00%> (-0.57%) ⬇️
cmd/skaffold/app/cmd/debug.go 100.00% <100.00%> (ø)
cmd/skaffold/app/cmd/runner.go 64.17% <100.00%> (ø)
pkg/skaffold/initializer/build/builders.go 42.85% <0.00%> (-17.15%) ⬇️
pkg/skaffold/build/cluster/logs.go 0.00% <0.00%> (-16.67%) ⬇️
pkg/skaffold/event/v2/status_check.go 85.45% <0.00%> (-14.55%) ⬇️
pkg/skaffold/kubernetes/watcher.go 67.10% <0.00%> (-14.53%) ⬇️
... and 118 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c8ba9f0...0df3994. Read the comment docs.

@briandealwis briandealwis changed the title update util.StringSlice to new stringslice lib to fix build error fix: use new stringslice lib Oct 20, 2021
@briandealwis
Copy link
Member

Merging as the Kaniko failure on Kokoro is unrelated.

@briandealwis briandealwis merged commit e56ec51 into GoogleContainerTools:main Oct 20, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants