-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(sync): more descriptive error for custom build inferred sync misconfiguration #6778
Conversation
Codecov Report
@@ Coverage Diff @@
## main #6778 +/- ##
==========================================
- Coverage 70.48% 69.11% -1.37%
==========================================
Files 515 547 +32
Lines 23150 25029 +1879
==========================================
+ Hits 16317 17299 +982
- Misses 5776 6567 +791
- Partials 1057 1163 +106
Continue to review full report at Codecov.
|
Looks like there are some build failures here @nkubala |
Can you take a look at these test errors @nkubala? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Have a question about the need for two separate errors here
deb52b2
to
2cc83b4
Compare
fixes: #6772
this change improves the error message we surface when an inferred sync rule is configured with a custom builder that doesn't have the required dependencies.