Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(sync): more descriptive error for custom build inferred sync misconfiguration #6778

Merged
merged 3 commits into from
Nov 10, 2021

Conversation

nkubala
Copy link
Contributor

@nkubala nkubala commented Oct 29, 2021

fixes: #6772

this change improves the error message we surface when an inferred sync rule is configured with a custom builder that doesn't have the required dependencies.

@nkubala nkubala requested a review from a team as a code owner October 29, 2021 18:34
@nkubala nkubala requested a review from briandealwis October 29, 2021 18:34
@google-cla google-cla bot added the cla: yes label Oct 29, 2021
@codecov
Copy link

codecov bot commented Oct 29, 2021

Codecov Report

Merging #6778 (2cc83b4) into main (290280e) will decrease coverage by 1.36%.
The diff coverage is 77.08%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #6778      +/-   ##
==========================================
- Coverage   70.48%   69.11%   -1.37%     
==========================================
  Files         515      547      +32     
  Lines       23150    25029    +1879     
==========================================
+ Hits        16317    17299     +982     
- Misses       5776     6567     +791     
- Partials     1057     1163     +106     
Impacted Files Coverage Δ
cmd/skaffold/app/cmd/deploy.go 52.00% <ø> (-1.85%) ⬇️
cmd/skaffold/app/cmd/flags.go 91.00% <ø> (+0.18%) ⬆️
cmd/skaffold/app/cmd/render.go 36.66% <0.00%> (-4.72%) ⬇️
cmd/skaffold/skaffold.go 0.00% <ø> (ø)
cmd/skaffold/app/cmd/lint.go 42.85% <60.00%> (ø)
cmd/skaffold/app/cmd/cmd.go 72.13% <100.00%> (+1.07%) ⬆️
cmd/skaffold/app/cmd/debug.go 100.00% <100.00%> (ø)
cmd/skaffold/app/cmd/runner.go 64.17% <100.00%> (ø)
cmd/skaffold/app/flags/image.go 76.27% <100.00%> (+3.72%) ⬆️
cmd/skaffold/app/skaffold.go 76.19% <100.00%> (-8.43%) ⬇️
... and 160 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 23f65f2...2cc83b4. Read the comment docs.

@briandealwis briandealwis changed the title fix(error): more descriptive error for custom build inferred sync misconfiguration fix(sync): more descriptive error for custom build inferred sync misconfiguration Oct 29, 2021
@briandealwis
Copy link
Member

Looks like there are some build failures here @nkubala

@briandealwis
Copy link
Member

Can you take a look at these test errors @nkubala?

Copy link
Contributor

@MarlonGamez MarlonGamez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Have a question about the need for two separate errors here

@pull-request-size pull-request-size bot added size/M and removed size/S labels Nov 10, 2021
@nkubala nkubala merged commit 256f88a into GoogleContainerTools:main Nov 10, 2021
@nkubala nkubala deleted the custom-infer-sync branch January 7, 2022 19:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

SyncMap is not supported by this builder - sync infer - custom script
4 participants