Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: add diagnostic severity info to skaffold lint rules #6862

Conversation

aaron-prindle
Copy link
Contributor

Adds diagnostic severity info the skaffold lint rules that skaffold lint emits. This is passed onto the skaffold lsp to be displayed correctly in an IDE. Currently all of the lint rules are at Warning level which is yellow in the IDE. There are the following severity types (from - https://microsoft.github.io/language-server-protocol/specifications/specification-3-17/#diagnosticSeverity):

  • Error (red underline, shows up in Problems section)
  • Warning (yellow underline, maybe shows up in Problems section?)
  • Info (blue underline)
  • Hint (subtle ellipses underline at the beginning area)

@aaron-prindle aaron-prindle requested a review from a team as a code owner November 15, 2021 23:39
@google-cla google-cla bot added the cla: yes label Nov 15, 2021
@aaron-prindle aaron-prindle force-pushed the add-diagnostic-severity-to-lint branch from d1a1b70 to 4e9dd75 Compare November 15, 2021 23:40
@aaron-prindle aaron-prindle changed the title add diagnostic severity info to skaffold lint rules fix: add diagnostic severity info to skaffold lint rules Nov 15, 2021
@codecov
Copy link

codecov bot commented Nov 16, 2021

Codecov Report

Merging #6862 (4e9dd75) into main (290280e) will decrease coverage by 1.34%.
The diff coverage is 61.83%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #6862      +/-   ##
==========================================
- Coverage   70.48%   69.13%   -1.35%     
==========================================
  Files         515      547      +32     
  Lines       23150    25078    +1928     
==========================================
+ Hits        16317    17338    +1021     
- Misses       5776     6576     +800     
- Partials     1057     1164     +107     
Impacted Files Coverage Δ
cmd/skaffold/app/cmd/deploy.go 52.00% <ø> (-1.85%) ⬇️
cmd/skaffold/app/cmd/dev.go 84.61% <0.00%> (ø)
cmd/skaffold/app/cmd/flags.go 91.00% <0.00%> (+0.18%) ⬆️
cmd/skaffold/app/cmd/render.go 36.66% <0.00%> (-4.72%) ⬇️
cmd/skaffold/skaffold.go 0.00% <0.00%> (ø)
cmd/skaffold/app/cmd/inspect_tests.go 62.50% <14.28%> (-1.14%) ⬇️
cmd/skaffold/app/cmd/fix.go 68.85% <40.00%> (-7.62%) ⬇️
cmd/skaffold/app/cmd/lint.go 42.85% <42.85%> (ø)
cmd/skaffold/app/cmd/find_configs.go 48.88% <50.00%> (+0.24%) ⬆️
cmd/skaffold/app/skaffold.go 76.19% <70.00%> (-8.43%) ⬇️
... and 162 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9e8762f...4e9dd75. Read the comment docs.

Copy link
Contributor

@gsquared94 gsquared94 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@gsquared94 gsquared94 merged commit ec848b9 into GoogleContainerTools:main Nov 16, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants