Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support docker build --cache-from #737

Merged
merged 2 commits into from
Jun 25, 2018
Merged

Support docker build --cache-from #737

merged 2 commits into from
Jun 25, 2018

Conversation

dgageot
Copy link
Contributor

@dgageot dgageot commented Jun 24, 2018

No description provided.

@dgageot dgageot force-pushed the cache-from branch 2 times, most recently from ccd81c0 to 9bf08ef Compare June 25, 2018 05:06
dgageot added 2 commits June 25, 2018 22:42
@dgageot
Add support for cache-from
d4afc5f 
Fixes GoogleContainerTools#701

Signed-off-by: David Gageot <david@gageot.net>
@dgageot
Remove duplication
536415f 
Signed-off-by: David Gageot <david@gageot.net>
@balopat balopat self-assigned this Jun 25, 2018
balopat
balopat approved these changes Jun 25, 2018
View reviewed changes
Copy link
Contributor

@balopat balopat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@balopat
Copy link
Contributor

balopat commented Jun 25, 2018

I did think a little bit about keeping the BuildOptions around but I guess you're right to get rid of it - if there are skaffold specific image building options we can reintroduce a narrower interface + the output buffer really doesn't have to belong there.

@dgageot
Copy link
Contributor Author

dgageot commented Jun 25, 2018

@balopat Thanks for your time!

@dgageot dgageot merged commit e596794 into GoogleContainerTools:master Jun 25, 2018
@dgageot dgageot deleted the cache-from branch December 28, 2018 07:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@balopat balopat balopat approved these changes

@dlorenc dlorenc Awaiting requested review from dlorenc

@r2d4 r2d4 Awaiting requested review from r2d4

@viglesiasce viglesiasce Awaiting requested review from viglesiasce

Assignees

@balopat balopat

Labels
ready-for-review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@dgageot @balopat