Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Extract code to tail logs #924

Merged
merged 4 commits into from
Aug 24, 2018

Conversation

dgageot
Copy link
Contributor

@dgageot dgageot commented Aug 23, 2018

  • Remove duplication by extracting the code to tail logs
  • Handle ctrl-c in all long running commands

ping @priyawadhwa

Signed-off-by: David Gageot <david@gageot.net>
Signed-off-by: David Gageot <david@gageot.net>
@dgageot dgageot requested review from balopat and r2d4 as code owners August 23, 2018 06:03
@codecov-io
Copy link

codecov-io commented Aug 23, 2018

Codecov Report

Merging #924 into master will increase coverage by 0.04%.
The diff coverage is 11.11%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #924      +/-   ##
==========================================
+ Coverage   41.71%   41.75%   +0.04%     
==========================================
  Files          61       61              
  Lines        2522     2524       +2     
==========================================
+ Hits         1052     1054       +2     
+ Misses       1356     1355       -1     
- Partials      114      115       +1
Impacted Files Coverage Δ
cmd/skaffold/app/cmd/build.go 0% <0%> (ø) ⬆️
cmd/skaffold/app/cmd/deploy.go 0% <0%> (ø) ⬆️
pkg/skaffold/config/options.go 81.81% <0%> (-18.19%) ⬇️
cmd/skaffold/app/cmd/dev.go 0% <0%> (ø) ⬆️
cmd/skaffold/app/cmd/delete.go 0% <0%> (ø) ⬆️
cmd/skaffold/app/cmd/run.go 0% <0%> (ø) ⬆️
pkg/skaffold/runner/runner.go 55.11% <100%> (+0.51%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 80a04db...e4fdba6. Read the comment docs.

Signed-off-by: David Gageot <david@gageot.net>
@dgageot dgageot merged commit 80d365c into GoogleContainerTools:master Aug 24, 2018
@dgageot dgageot deleted the extract-tail-logs branch December 28, 2018 07:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants