fix: revert cache lookup changes #9313
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
ericzzzzzzz
commented
Feb 15, 2024
•
ericzzzzzzz
commented
- Revert the changes from fix(lookupRemote): fixed lookup.go lookupRemote to compare remote and cached digests #9278 , fix: Scope Issue with the 'entry' variable when looking up remote images and tests additions #9211, fix: puling images when working with a remote repository (#9177) #9181
- The rational is here : fix(lookupRemote): fixed lookup.go lookupRemote caching mechanism #9306 (comment)
…mote and cached digests (GoogleContainerTools#9278)" This reverts commit 9ff4546.
…mote images and tests additions (GoogleContainerTools#9211)" This reverts commit ffe769c.
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #9313 +/- ##
==========================================
- Coverage 70.48% 63.55% -6.93%
==========================================
Files 515 635 +120
Lines 23150 32781 +9631
==========================================
+ Hits 16317 20834 +4517
- Misses 5776 10340 +4564
- Partials 1057 1607 +550 ☔ View full report in Codecov by Sentry. |
renzodavid9
approved these changes
Feb 15, 2024
|
Will there be a patch release soon? |
|
Ping, any chance for a new release? We're badly affected by this at $WORK, and I'd prefer very much to simply ask all our devs to upgrade their Skaffold to the newest version from official sources, rather than creating an unofficial distribution channel with an in-house-built Skaffold binary 😞 CC @ericzzzzzzz 🙏 |
|
Gently ping. Any patch release? |
zasgar
pushed a commit
to gimbal-ai/gimbal
that referenced
this pull request
Aug 15, 2024
Summary: @nserrino and I recently ran into some issues where skaffold wouldn't rebuild a new UI image despite there being changes to the code. On further investigation, it looks like this was a bug in skaffold. Upgrade skaffold to ensure that we don't run into this again. See GoogleContainerTools/skaffold#9313 Relevant Issues: N/A Type of change: /kind infra Test Plan: skaffolding controlplane should still work, and update images as expected. Signed-off-by: Vihang Mehta <vihang@gimletlabs.ai> GitOrigin-RevId: f9a969039e46718e92a0f66185ce8f2d25417daf
zasgar
pushed a commit
to gimbal-ai/gimbal
that referenced
this pull request
Aug 28, 2024
Summary: @nserrino and I recently ran into some issues where skaffold wouldn't rebuild a new UI image despite there being changes to the code. On further investigation, it looks like this was a bug in skaffold. Upgrade skaffold to ensure that we don't run into this again. See GoogleContainerTools/skaffold#9313 Relevant Issues: N/A Type of change: /kind infra Test Plan: skaffolding controlplane should still work, and update images as expected. Signed-off-by: Vihang Mehta <vihang@gimletlabs.ai> GitOrigin-RevId: f9a969039e46718e92a0f66185ce8f2d25417daf
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.