Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(docs): fix docs build for v1 and v2 #9467

Merged
merged 1 commit into from
Aug 29, 2024
Merged

fix(docs): fix docs build for v1 and v2 #9467

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion deploy/docs-v2/local-preview.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,5 +26,5 @@ for dir in $(find ${DOCS_DIR} -mindepth 1 -maxdepth 1 -type d | grep -v themes |
MOUNTS="${MOUNTS} -v $dir:/app/docs/$(basename $dir):ro"
done

docker build --platform linux/amd64 -t skaffold-docs-previewer --target runtime_deps deploy/webhook
docker build --platform linux/amd64 -t skaffold-docs-previewer --target runtime_deps deploy/webhook-v2
docker run --platform linux/amd64 --rm -ti -p 1313:1313 ${MOUNTS} skaffold-docs-previewer $@
2 changes: 1 addition & 1 deletion deploy/webhook-v2/Dockerfile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -37,7 +37,7 @@ ENV KUBECTL_URL https://storage.googleapis.com/kubernetes-release/release/${KUBE
RUN wget -O kubectl "${KUBECTL_URL}"
RUN chmod +x kubectl

FROM node:12.22.7-stretch as runtime_deps
FROM node:16-stretch as runtime_deps
ENV FIREBASE_TOOLS_VERSION 7.13.1
RUN npm install -g firebase-tools@${FIREBASE_TOOLS_VERSION} postcss postcss-cli
WORKDIR /app/docs
Expand Down
2 changes: 1 addition & 1 deletion deploy/webhook/Dockerfile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -37,7 +37,7 @@ ENV KUBECTL_URL https://storage.googleapis.com/kubernetes-release/release/${KUBE
RUN wget -O kubectl "${KUBECTL_URL}"
RUN chmod +x kubectl

FROM node:12.22.7-stretch as runtime_deps
FROM node:16-stretch as runtime_deps
ENV FIREBASE_TOOLS_VERSION 7.13.1
RUN npm install -g firebase-tools@${FIREBASE_TOOLS_VERSION} postcss postcss-cli
WORKDIR /app/docs
Expand Down
Loading