Supply position parameter to remaining configuration fields (#7874) #7896
+24
−5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Supply position parameter to remaining configuration fields PR #7504 added support to specifiy an explicit position on configuration fields. This adds constructors to the remaning configuration fields that were lacking this option: DropdownField, ListField and NumberField. * Reduce some duplication Co-authored-by: Bernd Ahlers <bernd@graylog.com> (cherry picked from commit 1bccb32)
bernd
approved these changes
Apr 16, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR #7504 added support to specify an explicit position on configuration fields.
This adds constructors to the remaining configuration fields
that were lacking this option:
DropdownField,ListFieldandNumberField.Co-authored-by: Bernd Ahlers bernd@graylog.com
(cherry picked from commit 1bccb32)