Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support PHP 8 #102

Merged
merged 3 commits into from
Oct 29, 2020
Merged

Support PHP 8 #102

merged 3 commits into from
Oct 29, 2020
+254 −167

Conversation

vincentchalamon
Copy link
Collaborator

@vincentchalamon vincentchalamon commented Oct 27, 2020 •
edited
Loading

Q A
Bug fix? no
New feature? no
BC breaks? no
Deprecations? no
Tests pass? yes
Fixed tickets
License MIT
  • Fix deprecations
  • Use symfony/phpunit-bridge
  • Update CI configuration
  • Revamp features app
  • Support PHP 8
  • Test with Symfony 5.1

Sorry, something went wrong.

@vincentchalamon vincentchalamon self-assigned this Oct 27, 2020
@codecov
Copy link

codecov bot commented Oct 27, 2020 •
edited
Loading

Codecov Report

Merging #102 into v5 will decrease coverage by 0.34%.
The diff coverage is 38.46%.

Impacted file tree graph

@@             Coverage Diff              @@
##                 v5     #102      +/-   ##
============================================
- Coverage     77.93%   77.58%   -0.35%     
- Complexity      233      237       +4     
============================================
  Files            36       36              
  Lines           997     1004       +7     
============================================
+ Hits            777      779       +2     
- Misses          220      225       +5
Flag Coverage Δ Complexity Δ
#phpunit 77.58% <38.46%> (-0.35%) 237.00 <0.00> (+4.00) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ Complexity Δ
src/Grant/JwtGrant.php 0.00% <0.00%> (ø) 9.00 <0.00> (+4.00)
src/DependencyInjection/Configuration.php 98.87% <71.42%> (-1.13%) 7.00 <0.00> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c516006...df07a95. Read the comment docs.

@vincentchalamon vincentchalamon force-pushed the feature/php-8 branch 3 times, most recently from ad7fe58 to b2b4ca7 Compare October 27, 2020 10:45
@vincentchalamon vincentchalamon changed the title [WIP] Support PHP 8 Support PHP 8 Oct 27, 2020
@vincentchalamon vincentchalamon marked this pull request as draft October 27, 2020 10:47
@vincentchalamon vincentchalamon added the Hacktoberfest good to be elligible hacktoberfest label Oct 27, 2020
@vincentchalamon vincentchalamon force-pushed the feature/php-8 branch 18 times, most recently from ba93d05 to 6beafef Compare October 28, 2020 11:44
@vincentchalamon vincentchalamon marked this pull request as ready for review October 28, 2020 11:53
@vincentchalamon vincentchalamon marked this pull request as draft October 28, 2020 11:53
@vincentchalamon vincentchalamon added waiting PR is waiting for external updates and removed Hacktoberfest good to be elligible hacktoberfest labels Oct 28, 2020
@vincentchalamon vincentchalamon force-pushed the feature/php-8 branch 13 times, most recently from ca219f4 to ad09dc5 Compare October 29, 2020 14:05
@vincentchalamon vincentchalamon added Hacktoberfest good to be elligible hacktoberfest and removed waiting PR is waiting for external updates labels Oct 29, 2020
@vincentchalamon vincentchalamon marked this pull request as ready for review October 29, 2020 14:14
@vincentchalamon
Support PHP 8

Verified

This commit was signed with the committer’s verified signature.
vincentchalamon Vincent
GPG key ID: 428774B1FEA87550
Verified
Learn about vigilant mode
a30ba59
GregoireHebert
GregoireHebert approved these changes Oct 29, 2020
View reviewed changes
Copy link
Owner

@GregoireHebert GregoireHebert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, just 1 adjustment that might be irrelevant and 1 slight improvement, but really related to the PR.

vincentchalamon and others added 2 commits October 29, 2020 16:19
@vincentchalamon @GregoireHebert
Update src/DependencyInjection/Configuration.php

Verified

This commit was created on github.com and signed with GitHub’s verified signature. The key has expired.
GPG key ID: 4AEE18F83AFDEB23
Expired
Verified
Learn about vigilant mode
5d455d3 
Co-authored-by: Grégoire Hébert <gregoire@les-tilleuls.coop>
@vincentchalamon
bump php version

Verified

This commit was signed with the committer’s verified signature.
vincentchalamon Vincent
GPG key ID: 428774B1FEA87550
Verified
Learn about vigilant mode
df07a95
@GregoireHebert
Copy link
Owner

Thank you @vincentchalamon :D
you rock!

@vincentchalamon vincentchalamon merged commit 3092096 into v5 Oct 29, 2020
@vincentchalamon vincentchalamon deleted the feature/php-8 branch October 29, 2020 15:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@GregoireHebert GregoireHebert

Assignees

@vincentchalamon vincentchalamon

Labels
Hacktoberfest good to be elligible hacktoberfest hacktoberfest-accepted
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@vincentchalamon @GregoireHebert