Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix #97 #103

Merged
merged 1 commit into from
Oct 28, 2020
Merged

Fix #97 #103

merged 1 commit into from
Oct 28, 2020

Conversation

vincentchalamon
Copy link
Collaborator

Q A
Bug fix? no
New feature? yes
BC breaks? no
Deprecations? no
Tests pass? yes
Fixed tickets #97
License MIT

@vincentchalamon vincentchalamon self-assigned this Oct 27, 2020
@vincentchalamon vincentchalamon linked an issue Oct 27, 2020 that may be closed by this pull request
[Help] Change Signer Name and Email #97
Closed
@vincentchalamon vincentchalamon added the Hacktoberfest good to be elligible hacktoberfest label Oct 27, 2020
@vincentchalamon vincentchalamon force-pushed the issues/97 branch 2 times, most recently from fb9cf28 to 22ab836 Compare October 27, 2020 15:12
@codecov
Copy link

codecov bot commented Oct 27, 2020 •
edited
Loading

Codecov Report

Merging #103 into v5 will increase coverage by 0.58%.
The diff coverage is 100.00%.

Impacted file tree graph

@@             Coverage Diff              @@
##                 v5     #103      +/-   ##
============================================
+ Coverage     77.35%   77.93%   +0.58%     
- Complexity      229      233       +4     
============================================
  Files            36       36              
  Lines           989      997       +8     
============================================
+ Hits            765      777      +12     
+ Misses          224      220       -4
Flag Coverage Δ Complexity Δ
#phpunit 77.93% <100.00%> (+0.58%) 233.00 <2.00> (+4.00)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ Complexity Δ
src/Controller/Sign.php 94.11% <100.00%> (+1.80%) 7.00 <0.00> (+2.00)
src/EnvelopeBuilder.php 28.09% <100.00%> (+5.87%) 49.00 <2.00> (+2.00)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3e8aac3...ad8ac87. Read the comment docs.

@vincentchalamon vincentchalamon marked this pull request as ready for review October 27, 2020 15:16
GregoireHebert
GregoireHebert requested changes Oct 27, 2020
View reviewed changes
GregoireHebert
GregoireHebert approved these changes Oct 28, 2020
View reviewed changes
Copy link
Owner

@GregoireHebert GregoireHebert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

<3

@vincentchalamon vincentchalamon merged commit d38ab14 into v5 Oct 28, 2020
@vincentchalamon vincentchalamon deleted the issues/97 branch October 28, 2020 07:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@GregoireHebert GregoireHebert GregoireHebert approved these changes

Assignees

@vincentchalamon vincentchalamon

Labels
Hacktoberfest good to be elligible hacktoberfest
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Help] Change Signer Name and Email
2 participants
@vincentchalamon @GregoireHebert