Fix CI + fix for lcobucci/jwt:^4.0 #104
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
vincentchalamon
commented
Nov 25, 2020
vincentchalamon
commented
| Q | A |
|---|---|
| Bug fix? | no |
| New feature? | no |
| BC breaks? | no |
| Deprecations? | no |
| Tests pass? | yes |
| Fixed tickets | |
| License | MIT |
vincentchalamon
force-pushed
the
fix/ci
branch
4 times, most recently
from
f25825a to
893abca
Compare
vincentchalamon
force-pushed
the
fix/ci
branch
4 times, most recently
from
2b25b1b to
4be67c4
Compare
Codecov Report
@@ Coverage Diff @@
## v5 #104 +/- ##
============================================
- Coverage 77.58% 77.03% -0.56%
+ Complexity 237 220 -17
============================================
Files 36 36
Lines 1004 1032 +28
============================================
+ Hits 779 795 +16
- Misses 225 237 +12
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
vincentchalamon
force-pushed
the
fix/ci
branch
8 times, most recently
from
fe71490 to
8596be5
Compare
vincentchalamon
force-pushed
the
fix/ci
branch
from
8596be5 to
6296ca3
Compare
GregoireHebert
requested changes
Nov 27, 2020
Co-authored-by: Grégoire Hébert <gregoire@les-tilleuls.coop>
GregoireHebert
approved these changes
Nov 27, 2020
|
Thank you Vincent <3 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.