fix: android build

[yihong0618]

I hereby agree to the terms of the GreptimeDB CLA.

Refer to a related PR or issue link (optional)

@WenyXu @sunng87
This patch finish #5322

android build still failed after #5327
need very tiny fix, this patch did it.

error:
make build-android-bin

   Compiling meta-srv v0.12.0 (/greptimedb/src/meta-srv)
   Compiling datanode v0.12.0 (/greptimedb/src/datanode)
   Compiling cli v0.12.0 (/greptimedb/src/cli)
   Compiling frontend v0.12.0 (/greptimedb/src/frontend)
   Compiling flow v0.12.0 (/greptimedb/src/flow)
   Compiling plugins v0.12.0 (/greptimedb/src/plugins)
   Compiling cmd v0.12.0 (/greptimedb/src/cmd)
error[E0599]: no method named `detect_server_addr` found for struct `meta_srv::metasrv::MetasrvOptions` in the current scope
   --> src/cmd/src/metasrv.rs:276:14
    |
276 |         opts.detect_server_addr();
    |              ^^^^^^^^^^^^^^^^^^ method not found in `MetasrvOptions`

For more information about this error, try `rustc --explain E0599`.
error: could not compile `cmd` (lib) due to 1 previous error
warning: build failed, waiting for other jobs to finish...
note: If the build failed due to a missing target, you can run this command:
note: 
note:     rustup target install aarch64-linux-android
make: *** [Makefile:75: build] Error 101
make: *** [build-android-bin] Error 2

What's changed and what's your intention?

PR Checklist

Please convert it to a draft if some of the following conditions are not met.

• I have written the necessary rustdoc comments.
• I have added the necessary unit tests and integration tests.
• This PR requires documentation updates.
• API changes are backward compatible.
• Schema or data changes are backward compatible.

[coderabbitai]

Important

Review skipped

Auto reviews are disabled on this repository.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Finishing Touches

• 📝 Generate Docstrings

---

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>, please review it.
  • Generate unit testing code for this file.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit testing code for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
  • @coderabbitai read src/utils.ts and generate unit testing code.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai generate docstrings to generate docstrings for this PR. (Beta)
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai anywhere in the PR title to generate the title automatically.

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.

[codecov]

Codecov Report

Attention: Patch coverage is 0% with 2 lines in your changes missing coverage. Please review.

Project coverage is 83.90%. Comparing base (0685ba2) to head (15b89a0).

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #5329      +/-   ##
==========================================
- Coverage   84.13%   83.90%   -0.24%     
==========================================
  Files        1181     1181              
  Lines      220905   220907       +2     
==========================================
- Hits       185868   185353     -515     
- Misses      35037    35554     +517     

[WenyXu]

greptimedb/src/meta-srv/src/metasrv.rs

Lines 207 to 235 in 0685ba2

	#[cfg(not(target_os = "android"))]
	pub fn detect_server_addr(&mut self) {
	if self.server_addr.is_empty() {
	match local_ip_address::local_ip() {
	Ok(ip) => {
	let detected_addr = format!(
	"{}:{}",
	ip,
	self.bind_addr
	.split(':')
	.nth(1)
	.unwrap_or(DEFAULT_METASRV_ADDR_PORT)
	);
	info!("Using detected: {} as server address", detected_addr);
	self.server_addr = detected_addr;
	}
	Err(e) => {
	error!("Failed to detect local ip address: {}", e);
	}
	}
	}
	}
	#[cfg(target_os = "android")]
	pub fn detect_hostname(&mut self) {
	if self.server_addr.is_empty() {
	common_telemetry::debug!("detect local IP is not supported on Android");
	}
	}

Hi @yihong0618,　Thank you for your testing! This typo was introduced by me. I believe it would be better to rename detect_hostname to detect_server_addr in MetasrvOptions.

Let me know what you think! 😊

[yihong0618]

greptimedb/src/meta-srv/src/metasrv.rs

Lines 207 to 235 in 0685ba2

	#[cfg(not(target_os = "android"))]
	pub fn detect_server_addr(&mut self) {
	if self.server_addr.is_empty() {
	match local_ip_address::local_ip() {
	Ok(ip) => {
	let detected_addr = format!(
	"{}:{}",
	ip,
	self.bind_addr
	.split(':')
	.nth(1)
	.unwrap_or(DEFAULT_METASRV_ADDR_PORT)
	);
	info!("Using detected: {} as server address", detected_addr);
	self.server_addr = detected_addr;
	}
	Err(e) => {
	error!("Failed to detect local ip address: {}", e);
	}
	}
	}
	}
	#[cfg(target_os = "android")]
	pub fn detect_hostname(&mut self) {
	if self.server_addr.is_empty() {
	common_telemetry::debug!("detect local IP is not supported on Android");
	}
	}

Hi @yihong0618,　Thank you for your testing! This typo was introduced by me. I believe it would be better to rename detect_hostname to detect_server_addr in MetasrvOptions.

Let me know what you think! 😊

of course will test and change it, thanks for the info, and good night

[yihong0618]

greptimedb/src/meta-srv/src/metasrv.rs

Lines 207 to 235 in 0685ba2

	#[cfg(not(target_os = "android"))]
	pub fn detect_server_addr(&mut self) {
	if self.server_addr.is_empty() {
	match local_ip_address::local_ip() {
	Ok(ip) => {
	let detected_addr = format!(
	"{}:{}",
	ip,
	self.bind_addr
	.split(':')
	.nth(1)
	.unwrap_or(DEFAULT_METASRV_ADDR_PORT)
	);
	info!("Using detected: {} as server address", detected_addr);
	self.server_addr = detected_addr;
	}
	Err(e) => {
	error!("Failed to detect local ip address: {}", e);
	}
	}
	}
	}
	#[cfg(target_os = "android")]
	pub fn detect_hostname(&mut self) {
	if self.server_addr.is_empty() {
	common_telemetry::debug!("detect local IP is not supported on Android");
	}
	}

Hi @yihong0618,　Thank you for your testing! This typo was introduced by me. I believe it would be better to rename detect_hostname to detect_server_addr in MetasrvOptions.

Let me know what you think! 😊

Done and waiting for the build for testing

passed

[WenyXu]

Thanks!