Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Filter Display of Apps By Permissions #353

Closed
MichaelDevon opened this issue Jul 26, 2024 · 14 comments
Closed

Filter Display of Apps By Permissions #353

MichaelDevon opened this issue Jul 26, 2024 · 14 comments
Labels
feature request This feature should be implemented

Comments

@MichaelDevon
Copy link

Is your feature request related to a problem? Please describe.
N/A

Describe the solution you'd like
For example, option to display only the apps that have internet permission.

Describe alternatives you've considered
N/A

Additional context
Since there are lots of permissions, this may need a submenu.

@Hamza417
Copy link
Owner

@MichaelDevon You can do that using Deep Search

@Hamza417 Hamza417 added the feature request This feature should be implemented label Jul 26, 2024
@MichaelDevon
Copy link
Author

Oh. Thanks then.

@Hamza417 Hamza417 added Q/A questions related to the project and app already exist this feature already exist or has an alternative available labels Jul 26, 2024
@Hamza417 Hamza417 reopened this Jul 26, 2024
@MichaelDevon
Copy link
Author

Did i give you an idea? 😃

@MichaelDevon
Copy link
Author

If i use Deep Search, can i only list System or User apps?

@Hamza417
Copy link
Owner

Did i give you an idea? 😃

Yes, Deep Search could be improved. I'll be updating the improvements here.

If i use Deep Search, can i only list System or User apps?

You can apply the same filters as Apps panel and perform the searches on the filtered dataset, including Tags if you do searches using hashtag #

@Hamza417 Hamza417 added wip currently being worked upon and expected to be available soon. and removed Q/A questions related to the project and app already exist this feature already exist or has an alternative available labels Jul 26, 2024
@MichaelDevon
Copy link
Author

Ohh i see. The sink icon. I thought it was part of the "open application settings" line.

Screenshot_20240726-202429

This could have its own line to avoid confusion.

@MichaelDevon
Copy link
Author

Wait. Even though i selected System in the filter menu, apps are still showing from the user partition:
Screenshot_20240726-202700

I must be doing something wrong.

Im trying to make a search that only shows system apps with internet.

Hamza417 added a commit that referenced this issue Jul 27, 2024
@Hamza417
Copy link
Owner

Even though i selected System in the filter menu, apps are still showing from the user partition:

I checked, and it's filtering properly, can you show me your filter configurations for Search?

@MichaelDevon
Copy link
Author

Screenshot_20240727-092109

I tried to mess around with it, and it seems that it only updates the list if i exit the app. Then on the next runtime it updates to the filters i selected propperly.
But for me, changing them while the app is open does nothing.

@Hamza417
Copy link
Owner

It was an issue in refreshing data that's causing it. I have fixed the issue and in the meantime you can manually refresh the list to refresh the properly filtered data. You don't need to restart the app, the refresh button will work the same.

@MichaelDevon
Copy link
Author

Oh i see. Its strange that the list flashes upon selecting an option. I thought it was refreshing by itself.

My only suggestion is to move the filter button to its own line for UX.

Thank you for the help. I like this app.

@Hamza417
Copy link
Owner

My only suggestion is to move the filter button to its own line for UX.

I'm still thinking about that. The placement of the button is off and doesn't match the UX of the app. I'll think of something.

I've also added lists of all permissions and trackers to easily look for queries to filter apps with specific permissions or trackers. This should make searching through apps easier.

@Hamza417
Copy link
Owner

I have added a collapsible menu in Search Box of Search panel. It'll allow me to add one or two button there without hurting the UI and make the filter button accessible. You'll also get to see a new, nice animation when you press the more button 😄

@Hamza417 Hamza417 removed the wip currently being worked upon and expected to be available soon. label Jul 28, 2024
@MichaelDevon
Copy link
Author

Wow! Good job! I'll be sure to test it when its out.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature request This feature should be implemented
Projects
None yet
Development

No branches or pull requests

2 participants