Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added zap stanza for QtPass v1.2.3 #58893

Closed
wants to merge 2 commits into from
Closed

Added zap stanza for QtPass v1.2.3 #58893

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
d65a4ae
Added zap stanza for QtPass v1.2.3
Feb 14, 2019
0647e59
Update qtpass.rb
vitorgalvao Feb 14, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions Casks/qtpass.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,4 +9,6 @@
homepage 'https://qtpass.org/'

app 'QtPass.app'

zap trash: '~/Library/Saved Application State/$(PRODUCT_BUNDLE_IDENTIFIER).savedState'
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You forgot to replace $(PRODUCT_BUNDLE_IDENTIFIER).

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I didn't actually; QtPass's directory is literally $(PRODUCT_BUNDLE_IDENTIFIER). That directory is created every time QtPass is quit.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That is a clear error, and one waiting for an accident to happen. Let’s wait for a fix.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Haha, good call. Thanks for opening up the issue.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Issue has been open for 20 days, and last commit was in December. I’m not sure anyone is checking the project.

Thank you for your contribution. I’ll close as that ID is potentially dangerous. We’ll revisit when/if they fix it on their end.

end