Revert "Add workaround for an empty zstd message" #1180
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bobrik
commented
Oct 1, 2018
| @@ -60,7 +60,7 @@ var ( | |||
| 0xFF, 0xFF, 0xFF, 0xFF, // key | |||
| 0x00, 0x00, 0x00, 0x0d, // len | |||
| // ZSTD data | |||
| 0x28, 0xb5, 0x2f, 0xfd, 0x24, 0x00, 0x01, 0x00, 0x00, 0x99, 0xe9, 0xd8, 0x51, | |||
There was a problem hiding this comment.
4 missing bytes are an optional checksum. zstd cli adds it, but DataDog's package does not and I don't see an option to enable it.
There's a message level checksum and checksum, so I think it's fine to leave it out.
There was a problem hiding this comment.
Opened an issue, but it should not be a blocker here:
bobrik
force-pushed
the
zstd-revert-empty-message-hack
branch
from
22ff4e4 to
1703c3b
Compare
bai
reviewed
Oct 2, 2018
message_test.go
Outdated
| @@ -53,14 +53,14 @@ var ( | |||
| } | |||
|
|
|||
| emptyZSTDMessage = []byte{ | |||
| 252, 62, 137, 23, // CRC | |||
| 180, 172, 84, 179, // CRC | |||
| 0x01, // version byte | |||
| 0x04, // attribute flags: lz4 | |||
This reverts commit 0f30d97. The issue was fixed in DataDog/zstd#42
bobrik
force-pushed
the
zstd-revert-empty-message-hack
branch
from
1703c3b to
7d77064
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This reverts commit 0f30d97.
The issue was fixed in DataDog/zstd#42
cc @Viq111 @jmoiron