Binding source for XMLSTOREDP #28
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
You'll need to sign off your commits. You can find the details on how to do that by clicking on the Details link for the DCO bot above. |
added 2 commits
February 11, 2019 09:42
Signed-off-by: Justin Taylor <JUSTIN@intranet.lorencook.com>
Signed-off-by: Justin Taylor <JUSTIN@intranet.lorencook.com>
Justin-E-Taylor
force-pushed
the
master
branch
from
38de552 to
dbc0dd4
Compare
kadler
requested changes
Feb 11, 2019
src/xmlstoredp.bnd
Outdated
| @@ -0,0 +1,19 @@ | |||
| strpgmexp pgmlvl(*CURRENT) signature('XMLSTOREDP 19039') | |||
There was a problem hiding this comment.
we should use signature(*GEN) here. These are store procedure targets and only designed to be called by the database. It doesn't care about signatures, only that the symbol is exported. This will also prevent users from attempting to link to it (though, I suspect nobody would).
The *SRVPGM is only used by a Db2 stored procedure, so the signature is irrelevant.
kadler
approved these changes
Feb 12, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#27
This binding source should export only procedures actually needed by the stored procedure. For the signature, I just used the *SRVPGM name and a date. I don't know what the "best practice" is for signatures. I made no attempt to retrieve the prior signature.