Lookup validity field to check if keys are valid #201
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Currently, the code checks the Ownertrust field [1] to look if a key should be considered as valid. However, the Ownertrust field should not be deemed to represent the level of confidence that a key is valid. Rather, it represents how much the user trusts in the owner of the key to understand correctly how key signing works and to strictly check fingerprints before signing keys. Ownertrust is used as input by the trust models to compute the validity of keys, which is printed by GnuPG in the Validity field. This commit changes the code to check the Validity field instead of the Ownertrust field. Keys which are at least marginally valid are also included in the user list dialog, however keys which are not fully valid are printed with dark orange background. [1] http://git.gnupg.org/cgi-bin/gitweb.cgi?p=gnupg.git;a=blob_plain;f=doc/DETAILS
|
This indeed seems to be a more valid way to handle the key trust. Merging to master, thank you very much for your contribution. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, the code checks the Ownertrust field [1] to look if a key should be considered as valid. However, the Ownertrust field should not be deemed to represent the level of confidence that a key is valid. Rather, it represents how much the user trusts in the owner of the key to understand correctly how key signing works and to strictly check fingerprints before signing keys. Ownertrust is used as input by the trust models to compute the validity of keys, which is printed by GnuPG in the Validity field.
This commit changes the code to check the Validity field instead of the Ownertrust field.
Keys which are at least marginally valid are also included in the user list dialog, however keys which are not fully valid are printed with dark orange background.
[1] http://git.gnupg.org/cgi-bin/gitweb.cgi?p=gnupg.git;a=blob_plain;f=doc/DETAILS