Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

API test suite failing for "develop" branch post 4.9.2 #5025

Closed
pdurbin opened this issue Sep 6, 2018 · 3 comments
Closed

API test suite failing for "develop" branch post 4.9.2 #5025

pdurbin opened this issue Sep 6, 2018 · 3 comments

Comments

@pdurbin
Copy link
Member

pdurbin commented Sep 6, 2018

I just ran the API test suite on the "phoenix" server and according to https://build.hmdc.harvard.edu:8443/job/phoenix.dataverse.org-apitest-develop/ sometime between August 24th (df3e31f) and September 6th (d149475) the API test suite started failing. Here's a screenshot:

screen shot 2018-09-06 at 2 46 56 pm

The phoenix server is described in the Dev Guide at http://guides.dataverse.org/en/4.9.2/developers/testing.html#the-phoenix-server

@matthew-a-dunlap
Copy link
Contributor

matthew-a-dunlap commented Sep 6, 2018

They are all related to the changes in #4565 around builtinuser. Thanks for running this Phil!

@matthew-a-dunlap matthew-a-dunlap self-assigned this Sep 6, 2018
matthew-a-dunlap added a commit that referenced this issue Sep 7, 2018
- Fixes one test and moves the error down on another
matthew-a-dunlap added a commit that referenced this issue Sep 7, 2018
-Fixes at least one broken IT test
matthew-a-dunlap added a commit that referenced this issue Sep 7, 2018
@pdurbin
Copy link
Member Author

pdurbin commented Sep 7, 2018

Pull request #5036 looks good to me. Moving to QA. @matthew-a-dunlap will be adding some testing notes.

@matthew-a-dunlap
Copy link
Contributor

Half of the reason the IT tests were failing is due to the IT Tests looking for email in builtinuser, when it no longer lives there.

The non-test changes were to:

  1. Fix api endpoints for account conversion to look for the returning email from the right place.
  2. Fix the authenticatedUser to strip leading/trailing spaces, which we supported already with builtinuser.

Testing this means confirming that both of these two pieces of code work as expected. Also maybe try changing a password and another basic account test or two to around email.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants