-
Notifications
You must be signed in to change notification settings - Fork 501
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Openaire fix for multiple productionPlaces #11194
Conversation
Made multiple in this PR: |
@jggautier yes, good catch. I left some comments on #9546. This PR fixes it so I added "closes #9546" to the description of this PR for the issue to get auto-closed on merge. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@ffritze thank for the pull request! This actually fixes an existing issue:
I went ahead and marked this PR as closing it and left some comments in it.
I'm close to approving this PR but please see my comments in this review. Thanks again!
Co-authored-by: Philip Durbin <philipdurbin@gmail.com>
@pdurbin I have added two test functions and added the the release note snippet. So eventually we are ready for the merge? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tests are passing: https://jenkins.dataverse.org/job/IQSS-Dataverse-Develop-PR/job/PR-11194/5/testReport/
@ffritze thanks for the PR and the extra tests! I'm approving this.
tests passed - merging PR |
What this PR does / why we need it:
Which issue(s) this PR closes:
Special notes for your reviewer:
Suggestions on how to test this:
Tests are written and adapted for this pull request. They are passing.
Does this PR introduce a user interface change? If mockups are available, please link/include them here:
Is there a release notes update needed for this change?:
Additional documentation: