Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MDC Adding server to processing state table to allow the processing script to run on multiple servers #11277

Merged
merged 20 commits into from
Mar 6, 2025

Conversation

stevenwinship
Copy link
Contributor

@stevenwinship stevenwinship commented Feb 19, 2025

What this PR does / why we need it: A server column is needed in the MDC processing state table in order to allow the processing to take place on more than one server. Counter processor needs to restart processing on the same server to take advantage of the already processed data. Also this keeps multiple servers from processing the same month's data.
Also updates needed to docs for counter_processor 1.06 release

Which issue(s) this PR closes: #11276

Special notes for your reviewer:

Suggestions on how to test this: See IT tests. Make API calls GET POST DELETE

Does this PR introduce a user interface change? If mockups are available, please link/include them here:No

Is there a release notes update needed for this change?: Included

Additional documentation:

@stevenwinship stevenwinship added Feature: Metrics + Reports Size: 3 A percentage of a sprint. 2.1 hours. FY25 Sprint 17 FY25 Sprint 17 (2025-02-12 - 2025-02-26) labels Feb 19, 2025
@stevenwinship stevenwinship self-assigned this Feb 19, 2025
@coveralls
Copy link

coveralls commented Feb 19, 2025

Coverage Status

coverage: 22.696% (-0.002%) from 22.698%
when pulling 77b059e on 11276-mdc-add-server-to-processing-state-db-table
into 9057892 on develop.

This comment has been minimized.

1 similar comment

This comment has been minimized.

@stevenwinship stevenwinship removed their assignment Feb 20, 2025

This comment has been minimized.

@stevenwinship stevenwinship self-assigned this Feb 20, 2025

This comment has been minimized.

@stevenwinship stevenwinship removed their assignment Feb 20, 2025
@scolapasta scolapasta added this to the 6.6 milestone Feb 24, 2025

This comment has been minimized.

@pdurbin pdurbin self-assigned this Feb 25, 2025
Copy link
Member

@pdurbin pdurbin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I didn't test this but it seems fine. Thanks for adding the SQL script for upgrade scenarios. I'm leaving a couple minor questions in this review.

Co-authored-by: Philip Durbin <philip_durbin@harvard.edu>
@stevenwinship stevenwinship removed their assignment Feb 25, 2025

This comment has been minimized.

This comment has been minimized.

@cmbz cmbz added the FY25 Sprint 18 FY25 Sprint 18 (2025-02-26 - 2025-03-12) label Feb 27, 2025

This comment has been minimized.

This comment has been minimized.

1 similar comment

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

2 similar comments

This comment has been minimized.

Copy link

github-actions bot commented Mar 5, 2025

📦 Pushed preview images as

ghcr.io/gdcc/dataverse:11276-mdc-add-server-to-processing-state-db-table
ghcr.io/gdcc/configbaker:11276-mdc-add-server-to-processing-state-db-table

🚢 See on GHCR. Use by referencing with full name as printed above, mind the registry name.

@ofahimIQSS
Copy link
Contributor

This PR has branch conflicts - please update. Thanks!

@ofahimIQSS ofahimIQSS removed their assignment Mar 6, 2025
@ofahimIQSS
Copy link
Contributor

Merging PR

@ofahimIQSS ofahimIQSS merged commit 09dfa60 into develop Mar 6, 2025
17 of 18 checks passed
@ofahimIQSS ofahimIQSS deleted the 11276-mdc-add-server-to-processing-state-db-table branch March 6, 2025 19:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Feature: Metrics + Reports FY25 Sprint 17 FY25 Sprint 17 (2025-02-12 - 2025-02-26) FY25 Sprint 18 FY25 Sprint 18 (2025-02-26 - 2025-03-12) Size: 3 A percentage of a sprint. 2.1 hours.
Projects
Status: Done 🧹
Development

Successfully merging this pull request may close these issues.

MDC: Add server to processing state db table Release Counter Processor under gdcc, switch docs from CDLUC3
6 participants