-
Notifications
You must be signed in to change notification settings - Fork 501
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
7046 dataverse 5 release notes #7164
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No need to accept all these changes. I'm exhausted now but I might take another look later.
|
||
<http://guides.dataverse.org/en/5.0/admin/metadataexport.html?highlight=export#batch-exports-through-the-api> | ||
|
||
17. For installations using DataCite, pre-register DOIs: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Since there is already a detailed section for this step, above - does it need to be here, in the upgrade-to-payara instruction - probably not?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We've done this previously, that is, added it in the notes above and called out and individual step.
I added a (Recommended for installations using DataCite) at the start of the instruction. I also added a note for Add doi.dataciterestapiurlstring
Let me know what you think following the updates in abc4d9b
done | ||
``` | ||
|
||
18. Set up Standalone Zipper Service if desired. Please consult the scripts/zipdownload/README.md in the Dataverse 5 source tree for more information. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
similarly, this is already explained in its own section above - not sure it needs to be repeated in the upgrade-to-payara instruction - ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I added the experimental note in abc4d9b. I think it's fine to add this in two different instruction formats and it matches what we've done in previous notes but if you feel strongly I can revisit. I don't do the upgrades myself so if this sort of thing is not helpful to mention multiple times I'm fine to adjust it.
@landreev on Xmx and Xms - perhaps the paragraph should've begun with "Adjust" or "Review" rather than set. The step was included a recommendation in the performance tuning document but I'm fine with having it removed, especially if it will cause confusion. |
What this PR does / why we need it:
The release notes for Dataverse 5!
Which issue(s) this PR closes:
Closes #7046
Special notes for your reviewer:
No longer a draft PR. Thanks for all the feedback so far!
Suggestions on how to test this:
Bring it into your favorite text editor and take a look.
Does this PR introduce a user interface change? If mockups are available, please link/include them here:
N/A
Is there a release notes update needed for this change?:
N/A
Additional documentation:
N/A