Add hir #318
Open
Add hir #318
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CosmicHorrorDev
added
C-refactor
Refactor Ast initialization in HtmlInterpreter to use Ast struct with AstOpts. Update Hir struct in hir.rs to replace root with nodes and parents vectors.
|
Really happy that you took up tackling this! Just as a heads up, it'll probably be at least a week before I can get around to reviewing this. I'm planning on merging this PR shortly after the v0.5 release, so that it has some time to chill in |
|
I'm up for getting this reviewed and working towards getting it merged still if you are @kokoISnoTarget. There isn't any work blocking it anymore |
|
Sure thing. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a first draft for #175
Fixes #305, #315 and gives a better error for #338