Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix the build on Windows using mingw #54

Merged
merged 2 commits into from
Mar 2, 2024
Merged

Fix the build on Windows using mingw #54

merged 2 commits into from
Mar 2, 2024

Conversation

philippefoubert
Copy link

  • static link to mingw libraries (to avoid path issues)
  • adjust the path conventions (drive letter) to be able to use existing bash scripts on Windows
  • add an install target to be able to build outside the source folder (and keep using existing bash scripts)

@philippefoubert philippefoubert mentioned this pull request Feb 27, 2024
Open
nhasabni
nhasabni approved these changes Feb 27, 2024
View reviewed changes
Copy link
Contributor

@nhasabni nhasabni left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @philippefoubert for the support! It looks great to me.

@philippefoubert
Copy link
Author

To fix the "[linux/macos]_build_and_test" checks that fail, use PR#53 (since it is not directly related to mingw, i have chosen to write an other PR for that)

@nhasabni
Fix the build on Windows using mingw: static link to mingw libraries …
cb8b939 
…(to avoid path issues),

adjust the path conventions (drive letter) to be able to use existing bash scripts on Windows,
add an install target to be able to build outside the source folder (and keep using existing bash scripts)
@nhasabni
Copy link
Contributor

@philippefoubert As a small request, can you please fix the style check errors? You can run cpplint tool on your end like: cpplint --filter=-build/include_subdir,-runtime/reference --recursive .

nhasabni
nhasabni approved these changes Mar 2, 2024
View reviewed changes
Copy link
Contributor

@nhasabni nhasabni left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks great! Thanks again for the change.

@nhasabni nhasabni merged commit 6c9a096 into IntelLabs:master Mar 2, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nirhasabnis nirhasabnis nirhasabnis approved these changes

@nhasabni nhasabni nhasabni approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@philippefoubert @nhasabni @nirhasabnis