Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Final updates (documentation, site configs, ...) for spack-stack-1.4.1 #669

Merged
merged 11 commits into from
Jul 14, 2023
Merged

Final updates (documentation, site configs, ...) for spack-stack-1.4.1 #669

merged 11 commits into from
Jul 14, 2023

Conversation

climbfuji
Copy link
Collaborator

@climbfuji climbfuji commented Jul 12, 2023 •
edited
Loading

Summary

Final updates for spack-stack-1.4.1:

  • Documentation
  • Site config updates for Hercules and Gaea C5
  • Tags instead of release branches

Testing

Installed on all platforms that are updated in the documentation, tested on about half of them

Applications affected

Primarily UFS WM; JEDI will use spack-stack-1.4.1 mainly for testing of bufr@12.

Systems affected

All systems updated in the documentation (but existing spack-stack-1.4.0 installs remain in place).

Dependencies

n/a

Issue(s) addressed

Resolves #637 (requires all boxes in the issue to be ticked or crossed out)

Checklist

  • This PR addresses one issue/problem/enhancement, or has a very good reason for not doing so.
  • These changes have been tested on the affected systems and applications.
  • All dependency PRs/issues have been resolved and this PR can be merged.

@climbfuji climbfuji self-assigned this Jul 13, 2023
@climbfuji climbfuji added the INFRA JEDI Infrastructure label Jul 13, 2023
@climbfuji climbfuji mentioned this pull request Jul 13, 2023
Closed
26 tasks
@climbfuji climbfuji changed the title WIP - Final updates (documentation, site configs, ...) for spack-stack-1.4.1 Final updates (documentation, site configs, ...) for spack-stack-1.4.1 Jul 13, 2023
@climbfuji climbfuji marked this pull request as ready for review July 13, 2023 19:35
@climbfuji
Copy link
Collaborator Author

@ulmononian I will need your help filling in the missing bits for AWS Parallel Works (in the preconfigured sites section).

@AlexanderRichert-NOAA I will need your help filling in the missing bits for Acorn (in the preconfigured sites section).

Thanks!

ulmononian
ulmononian reviewed Jul 13, 2023
View reviewed changes
doc/modulefile_templates/openmpi
@@ -31,7 +31,7 @@ unsetenv SLURM_EXPORT_ENV
setenv PSM2_PATH_SELECTION "static_base"
setenv SLURM_CPU_BIND "none"

# Settings specific for Cheyenne
# Settings specific for Cheyenne and Hercules
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

just wanted to check: why are these settings only needed for cheyenne and hercules?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Because every HPC has its own settings, depending on the interconnect, the scheduler settings etc.

@AlexanderRichert-NOAA
Copy link
Collaborator

The Acorn section is still current (and the installation path is correct).

srherbener
srherbener approved these changes Jul 13, 2023
View reviewed changes
Copy link
Collaborator

@srherbener srherbener left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Thanks for making all of these updates

@climbfuji
Copy link
Collaborator Author

@ulmononian @AlexanderRichert-NOAA Ready for your final blessings and then we can tag and send out the release!

ulmononian
ulmononian reviewed Jul 13, 2023
View reviewed changes
doc/source/PreConfiguredSites.rst Outdated
@@ -402,7 +395,7 @@ The following is required for building new spack environments and for using spac
module load ecflow/5.8.4

.. note::
Support for spack-stack-1.4.0 will be added later on develop. The instructions below are for an older release.
Support for spack-stack-1.4.1 will be added later on develop. The instructions below are for an older release.
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lines 398-417 could be removed and replaced with:

For ``spack-stack-1.4.1`` with Intel, load the following modules after loading miniconda and ecflow:

   module use /contrib/EPIC/spack-stack/spack-stack-1.4.1/envs/unified-dev/install/modulefiles/Core
   module load stack-intel/2021.3.0
   module load stack-intel-oneapi-mpi/2021.3.0
   module load stack-python/3.9.12
   module available

1.4.1 is installed on AWS, Azure, and GCP (by @mark-a-potts)

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please re-review 51ba4b8

@climbfuji climbfuji requested a review from ulmononian July 14, 2023 02:17
@climbfuji climbfuji merged commit be8f8dd into JCSDA:release/1.4.1 Jul 14, 2023
@climbfuji climbfuji deleted the feature/final_updates_spackstack141 branch July 14, 2023 12:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@srherbener srherbener srherbener approved these changes

@ulmononian ulmononian ulmononian approved these changes

@AlexanderRichert-NOAA AlexanderRichert-NOAA AlexanderRichert-NOAA approved these changes

Assignees

@climbfuji climbfuji

Labels
INFRA JEDI Infrastructure
Projects
No open projects
spack-stack-1.5.0 (2023 Q3)
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@climbfuji @AlexanderRichert-NOAA @srherbener @ulmononian