[read] reading cell region with blank rows works

DESCRIPTION

@@ -1,7 +1,7 @@
 Type: Package
 Package: openxlsx2
 Title: Read, Write and Edit 'xlsx' Files
-Version: 1.13
+Version: 1.13.0.9000
 Language: en-US
 Authors@R: c(
   person("Jordan Mark", "Barbone", email = "jmbarbone@gmail.com", role = "aut", comment = c(ORCID = "0000-0001-9788-3628")),

NEWS.md

@@ -1,3 +1,8 @@
+# openxlsx2 (development version)
+
+
+***************************************************************************
+
 # openxlsx2 1.13
 
 ## New features

R/read.R

@@ -253,6 +253,7 @@ wb_to_df <- function(
   sst <- attr(wb$sharedStrings, "text")
 
   rnams <- row_attr$r
+  rnams <- rnams[rnams %in% unique(cc$row_r)] # avoid blank row interference
 
   numfmt_date <- numfmt_is_date(wb$styles_mgr$styles$numFmts)
   xlsx_date_style <- style_is_date(wb$styles_mgr$styles$cellXfs, numfmt_date)

tests/testthat/test-read_from_created_wb.R

@@ -278,3 +278,26 @@ test_that("shared formulas are handled", {
   expect_equal(exp, got)
 
 })
+
+test_that("reading with blank rows works (#1272)", {
+
+  wb <- wb_workbook()$add_worksheet()$
+    add_data(dims = "A1", x = 1)$
+    add_data(dims = "A4:E4", x = rep(1, 5))
+
+  rr <- wb$worksheets[[1]]$sheet_data$row_attr
+
+  rr <- create_char_dataframe(names(rr), n = 2)
+  rr$r <- as.character(2:3)
+
+  wb$worksheets[[1]]$sheet_data$row_attr <- rbind(
+    wb$worksheets[[1]]$sheet_data$row_attr,
+    rr,
+    stringAsFactors = FALSE
+  )
+
+  got <- wb$to_df(dims = "A2:E3", col_names = FALSE)
+
+  expect_equal(c(2L, 5L), dim(got))
+
+})