Cleanup drawings and vmlDrawings reference #536
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
... a wasted night to read a file ...
|
Merging this, because it improves the current situation, but there might still be corner stones I haven't thought about. |
JanMarvin
added a commit
that referenced
this pull request
Feb 13, 2023
This ensures that drawings rId and chart num are correct. Fixes a regression that no longer allowed the assignment of multiple charts per worksheet.
JanMarvin
added a commit
that referenced
this pull request
Feb 13, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Just the sort of pull requests I like, touches all sorts of places of code. So it's also cluttered to the max. Joking aside, there is now a new field relships that contains the relationships of a worksheet. This can be addressed and used to manage drawings and vml.