refactor!: massive cleanup #293
Draft
+10,429
−13,593
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
they do not appear to be used; we can recover them from `git` history if someone is relying on them (but they should be encouraged to use the more general, in-use code)
This fixes all the current compilation warnings. IMPORTANT: many `processeEvent` methods were retrieving _several_ more banks than the method actually needed; this commit removes several unnecessary `DataEvent.getBank` calls. In general: - variables that are obviously unused have been deleted - variables that may have been used for debugging have been commented out
Plot viewing should use the web front-end, not custom canvases and PNG output; we can allow webserver access to those who need it. Similar to the removal of `main` methods, if someone depends on `plot` methods, we may restore them from `git` history. We remove unused code so that we don't have to waste time maintaining it.
…ite` This makes calling the monitor classes a bit more general: - for each event, call `processEvent` - at the end, call `write` In some cases, two methods were called after event processing; additional methods are now just called by `write`. There are still variations in the methods' parameters, as well as their constructors.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.