Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implemented Feature for using Config Files #11

Merged
merged 5 commits into from
Oct 9, 2021
Merged

Implemented Feature for using Config Files #11

merged 5 commits into from
Oct 9, 2021

Conversation

AmasiaNalbandian
Copy link
Contributor

@AmasiaNalbandian AmasiaNalbandian commented Oct 9, 2021

closes #10

Summary

I wrote a function to parse the json passed for the config file with a config flag. The function will take the values in the file and push them into the options to then continue creating the files as done previously in the code.

Steps to test:

  1. Use the following instructions from the readme to set up the program, until you reach the steps for running the program.
  2. Create a json file with the following flags:
{
	"input": "text.txt",
	"lang": "fr",
	"output": "./examples"
}

You can test without the lang and output file. You can also mix-up the order of the properties.
3. Run the command: ./yassgy.exe --config <file>
4. Look into the folder you set for the output, otherwise look into the dist folder.

Copy link
Owner

@JerryHue JerryHue left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is great!

Could you update the README to include this feature?

@JerryHue JerryHue self-requested a review October 9, 2021 04:14
Copy link
Owner

@JerryHue JerryHue left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great!

@JerryHue JerryHue merged commit 2eff94e into JerryHue:master Oct 9, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Allow users to use config flag
2 participants