Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Plugin works #27

Merged
merged 15 commits into from
Jan 24, 2025
Merged

Plugin works #27

merged 15 commits into from
Jan 24, 2025

Conversation

ilma4
Copy link
Contributor

@ilma4 ilma4 commented Jan 22, 2025

Plugin can be used and then dsl for config can be called

ilma4 added 3 commits January 21, 2025 15:22
# Conflicts:
#	kotlinx.fuzz.api/build.gradle.kts
#	kotlinx.fuzz.gradle/src/main/kotlin/kotlinx/fuzz/gradle/KFuzzPlugin.kt
#	kotlinx.fuzz.gradle/src/main/kotlin/kotlinx/fuzz/gradle/junit/KotlinxFuzzJunitEngine.kt
Replace direct objectInstance access with a new testInstance extension function, ensuring proper handling of class instantiation. This improves robustness and allows fallback to using a constructor when no objectInstance exists.
@ilma4 ilma4 added the in progress PR is not ready to be reviewed label Jan 22, 2025
@ilma4 ilma4 added ready for review PR is ready to be reviewed and removed in progress PR is not ready to be reviewed labels Jan 23, 2025
Copy link
Contributor

@DLochmelis33 DLochmelis33 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

some problems:

  1. fuzz task does nothing, I think this PR is a good time and place to fix that
  2. IDEA does not highlight @KFuzzTest as a runnable test. Should it?

@ilma4
Copy link
Contributor Author

ilma4 commented Jan 23, 2025

@DLochmelis33

some problems:

1. `fuzz` task does nothing, I think this PR is a good time and place to fix that

2. IDEA does not highlight `@KFuzzTest` as a runnable test. Should it?
  1. try ./gradlew kotlinx.fuzz.test:clean kotlinx.fuzz.test:fuzz. Currently it's somehow caching

@DLochmelis33
Copy link
Contributor

DLochmelis33 commented Jan 23, 2025

try ./gradlew kotlinx.fuzz.test:clean kotlinx.fuzz.test:fuzz. Currently it's somehow caching

Still the same:

image

And same in terminal.

@DLochmelis33
Copy link
Contributor

:fuzz started working after a random number of :clean-s of various kinds. Now I only have the IDEA highlighting question.

@ilma4 ilma4 requested a review from DLochmelis33 January 23, 2025 15:47
@ilma4
Copy link
Contributor Author

ilma4 commented Jan 23, 2025

:fuzz started working after a random number of :clean-s of various kinds. Now I only have the IDEA highlighting question.

Green arrow in IDEA appered after I added kotlin(test) to dependencies 🤷‍♂️

Copy link
Contributor

@DLochmelis33 DLochmelis33 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Finally works on my machine too! 👍

@AbdullinAM AbdullinAM self-requested a review January 24, 2025 13:13
Copy link
Member

@AbdullinAM AbdullinAM left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks and works good

@AbdullinAM AbdullinAM merged commit 69ce83a into main Jan 24, 2025
4 checks passed
@AbdullinAM AbdullinAM deleted the ilma4/plugin-works branch January 24, 2025 13:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready for review PR is ready to be reviewed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants