Fixing #607 + Refactoring #608
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
May 7, 2021 11:00
Added me/episodes and done some refactoring
Fixing the remove of epsides.
JohnnyCrazy
approved these changes
May 9, 2021
Closed
JohnnyCrazy
requested changes
May 10, 2021
| /// </summary> | ||
| /// <value></value> | ||
| [QueryParam("uris")] | ||
| public IList<string> URIs { get; } |
There was a problem hiding this comment.
I think this should be ids instead of uris. See: https://developer.spotify.com/documentation/web-api/reference/#endpoint-save-episodes-user
| namespace SpotifyAPI.Web | ||
| { | ||
| public class LibraryEpisodesRequest : RequestParams | ||
| { |
There was a problem hiding this comment.
The parameter market is missing here, see https://developer.spotify.com/documentation/web-api/reference/#endpoint-get-users-saved-episodes
|
@JohnnyCrazy should be OK now :) Sorry for the delay! |
|
Looks good! I will have one more detailed look and run some tests this week :) No worries regarding the delay, I'm happy you contributed! 👍🏼 |
|
Sorry for the delay here, looks very good! Thank you for your contribution 🙏 👍🏼 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added me/episodes and done some refactoring