Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feat/4060 multichain lag fix #323

Merged
merged 1 commit into from
Jan 30, 2025
Merged

Feat/4060 multichain lag fix #323

merged 1 commit into from
Jan 30, 2025

Conversation

bassgeta
Copy link
Contributor

@bassgeta bassgeta commented Jan 28, 2025 •
edited
Loading

Description up at the CDapp PR

@bassgeta bassgeta changed the base branch from master to feat/proxy-colonies-dev-env January 28, 2025 15:14
@bassgeta bassgeta marked this pull request as ready for review January 28, 2025 15:57
@bassgeta bassgeta mentioned this pull request Jan 28, 2025
Merged
@mmioana mmioana self-requested a review January 28, 2025 18:42
mmioana
mmioana approved these changes Jan 28, 2025
View reviewed changes
Copy link
Contributor

@mmioana mmioana left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Really like the new utils package as well as the use of the MultiChainInfo model ✨

Reviewed as part of the CDapp PR

iamsamgibbs
iamsamgibbs approved these changes Jan 29, 2025
View reviewed changes
Copy link
Contributor

@iamsamgibbs iamsamgibbs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed alongside the CDapp counterpart

@bassgeta bassgeta merged commit a4abbb3 into feat/proxy-colonies-dev-env Jan 30, 2025
1 check passed
@bassgeta bassgeta deleted the feat/4060-multichain-lag-fix branch January 30, 2025 10:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mmioana mmioana mmioana approved these changes

@iamsamgibbs iamsamgibbs iamsamgibbs approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@bassgeta @mmioana @iamsamgibbs