hotfix/bedgraph #242
Merged
hotfix/bedgraph #242
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #242 +/- ##
==========================================
+ Coverage 80.1% 80.89% +0.78%
==========================================
Files 7 7
Lines 367 382 +15
==========================================
+ Hits 294 309 +15
Misses 73 73
Continue to review full report at Codecov.
|
CiaranOMara
force-pushed
the
hotfix/bedgraph
branch
from
9e50f90 to
140c487
Compare
3 tasks
SimonDanisch
approved these changes
Nov 24, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR prevents
detect_bedgraphfrom unnecessarily parsing whole files by adding constraints that need to be overcome to allow the scan for bedGraph magic bytes to continue.My apologies for the speed issues that
detect_bedgraphhas caused.Fixes #241.