CI: improve the content of results.json #57632
Draft
+37
−29
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
IanButterworth
force-pushed
the
ib/results_json_enhance
branch
3 times, most recently
from
624b51c to
090581b
Compare
nsajko
reviewed
Mar 4, 2025
IanButterworth
force-pushed
the
ib/results_json_enhance
branch
from
c447c58 to
7bcad46
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
From investigating #57610 I'm concluding that buildkite annotations aren't well-suited to help distill/highlight failure information.
The results.json stuff and the relatively new test digest view on buildkite shows promise though, but our results.json are missing a lot of information to make it powerful.
This tries to fill it out more correctly/informatively, notably using the actual
showmethods rather than constructing something approximate.Based on https://buildkite.com/docs/test-engine/importing-json#json-test-results-data-reference-test-result-objects