Adapt Upstream Object's Costomizable Fields #10
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
flame/blis#583 introdues 4 additional user customizable function fields. As BLIS.jl was using an outdated duplication of blis.h:obj_t, upgrading blis_jll v0.8.1 would cause the whole BLAS interface to break down. This commit should resolve #9
Codecov Report
@@ Coverage Diff @@
## master #10 +/- ##
==========================================
+ Coverage 57.43% 57.78% +0.34%
==========================================
Files 25 25
Lines 484 488 +4
==========================================
+ Hits 278 282 +4
Misses 206 206
Continue to review full report at Codecov.
|
Prompted by #9, I should limit upgradability of this wrapper. Any upstream change should get checked for its influence on obj_t before getting imported. @e35cf91's additional fields should still be compatible with <=0.8.0 binaries since the leading entries of obj_t hasn't changed and here obj_t is allocated on Julia side
giordano
reviewed
Feb 19, 2022
| @@ -14,4 +14,4 @@ blis_jll = "6136c539-28a5-5bf0-87cc-b183200dce32" | |||
|
|
|||
| [compat] | |||
| julia = "1.4" | |||
| blis_jll = "0.8.0" | |||
| blis_jll = "< 0.8.2" | |||
There was a problem hiding this comment.
Thanks for the fix! Note that the registry won't like this, you should use instead something like
blis_jll = "0.8.0-0.8.1"(I hope I got the syntax right).
Out of curiosity, why excluding 0.8.2?
There was a problem hiding this comment.
Thanks.
There's no 0.8.2 yet. I'm somehow trying to exclude future releases being automatically installed, as it might change the contents of obj_t.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
flame/blis#583 introdues 4 additional user customizable function fields.
As BLIS.jl was using an outdated duplication of blis.h:obj_t, upgrading blis_jll v0.8.1 would cause the whole BLAS interface to break down.
Resolves #9
Resolves #8