Type hierarchy #4
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The `Particle` type now represents the concrete implementation for storing particle properties.
test: add Custom Particles test into runtest
There was a problem hiding this comment.
Copilot reviewed 3 out of 10 changed files in this pull request and generated no suggestions.
Files not reviewed (7)
- src/ChargedParticles.jl: Language not supported
- src/custom_particles.jl: Language not supported
- src/properties.jl: Language not supported
- src/types.jl: Language not supported
- test/custom_particles.jl: Language not supported
- test/runtests.jl: Language not supported
- test/types.jl: Language not supported
Comments skipped due to low confidence (1)
docs/src/api.md:13
- Confirm if the removal of
Particlefrom the documentation is intentional. If not, it should be added back.
Particle
- Make _special_particles.jl public visible - Update imports and exports accordingly
Beforerr
force-pushed
the
type-hierarchy
branch
from
5a87fe6 to
bac2c13
Compare
…icle`, and add functionality to process special particles
Beforerr
force-pushed
the
type-hierarchy
branch
from
bac2c13 to
ca05834
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change
ChargedParticleImplintoParticleand addCustomParticle