Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move JLLs to own folder #85

Merged
merged 2 commits into from
Mar 8, 2023
Merged

Move JLLs to own folder #85

merged 2 commits into from
Mar 8, 2023

Conversation

oxinabox
Copy link
Contributor

@oxinabox oxinabox commented Mar 8, 2023

DilumAluthge
DilumAluthge approved these changes Mar 8, 2023
View reviewed changes
Copy link
Member

@DilumAluthge DilumAluthge left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Can you also bump the minor version number, so that we can make a new release right after merging?

@DilumAluthge DilumAluthge merged commit 569bb9f into JuliaRegistries:master Mar 8, 2023
@DilumAluthge
Copy link
Member

Thanks!

JuliaRegistries/General#79128

@DilumAluthge
Copy link
Member

Actually: JuliaRegistries/General#79129

@DilumAluthge DilumAluthge mentioned this pull request Mar 8, 2023
Merged
@GunnarFarneback GunnarFarneback mentioned this pull request Mar 9, 2023
Merged
@KeithWM
Copy link

KeithWM commented Nov 15, 2023

I am considering overloading the package_relpath(::AbstractString) method to group some generated code in a local registry. (Not allowed to share details, sorry.) That would be a similar change to this one, but to me it feels wrong to have to overload this entire method to register packages in a custom location. Would there be some other way to write this method so that it is more elegantly extensible?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@DilumAluthge DilumAluthge DilumAluthge approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@oxinabox @DilumAluthge @KeithWM