Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Braidingtensor improvements #179

Merged
merged 7 commits into from
Nov 20, 2024
Merged

Braidingtensor improvements #179

merged 7 commits into from
Nov 20, 2024

Conversation

lkdvos
Copy link
Collaborator

@lkdvos lkdvos commented Nov 20, 2024

This PR fixes some things about BraidingTensor that were either not working or just wrong, along with fixing the whole braid(::AbstractTensorMap) part of the code since apparently that was just not working.
It also adds some tests to catch this better in the future

Copy link

codecov bot commented Nov 20, 2024

Codecov Report

Attention: Patch coverage is 88.88889% with 3 lines in your changes missing coverage. Please review.

Project coverage is 82.85%. Comparing base (f467a21) to head (acaef58).

Files with missing lines Patch % Lines
src/tensors/treetransformers.jl 80.00% 3 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #179      +/-   ##
==========================================
+ Coverage   81.39%   82.85%   +1.45%     
==========================================
  Files          42       42              
  Lines        5218     5219       +1     
==========================================
+ Hits         4247     4324      +77     
+ Misses        971      895      -76     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.


🚨 Try these New Features:

@Jutho
Copy link
Owner

Jutho commented Nov 20, 2024

It seems like you managed to break LRUCache?

@lkdvos
Copy link
Collaborator Author

lkdvos commented Nov 20, 2024

It was just infinite recursion: TensorMap(::BraidingTensor) calls blocks(::BraidingTensor) which was defined as blocks(TensorMap(::BraidingTensor)), and the stack just ran out of space in the hash 😉

@lkdvos
Copy link
Collaborator Author

lkdvos commented Nov 20, 2024

This should be ready to go

@Jutho Jutho merged commit 8b38973 into master Nov 20, 2024
12 checks passed
@lkdvos lkdvos deleted the ld-braidingtensor branch November 20, 2024 23:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants