-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add block-wise options #335
Conversation
This comment was marked as outdated.
This comment was marked as outdated.
06c15bc
to
3511db4
Compare
This comment was marked as outdated.
This comment was marked as outdated.
3511db4
to
93d29f3
Compare
455e5cc
to
452c508
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #335 +/- ##
==========================================
+ Coverage 61.72% 63.95% +2.22%
==========================================
Files 8 9 +1
Lines 695 774 +79
Branches 156 172 +16
==========================================
+ Hits 429 495 +66
- Misses 215 220 +5
- Partials 51 59 +8 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
@twyatt rebased & fixed |
This comment was marked as outdated.
This comment was marked as outdated.
452c508
to
81d38fb
Compare
81d38fb
to
b4b0ab6
Compare
@zalenskivolt I pushed a couple commits to restructure things a little. I changed the size to an Let me know what you think. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Very clean, tested and well documented, I love it!
see IANA CoAP Option Numbers
(Size1 was already implemented, some tests added)
TLS+ = TCP, TLS, and WebSockets