[SPIR-V] Support SPV_INTEL_arbitrary_precision_integers extension #250
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This patch adds support for TargetExtType/target(...) representing SPIR-V builtin types. After D135202, target(...) is the preferred way for representing SPIR-V builtin types in LLVM IR and the only working in the opaque pointer mode. In order to maintain compatibility with LLVM IR generated by older versions of Clang and LLVM/SPIR-V Translator, pointers-to-opaque-structs denoting SPIR-V/OpenCL builtin types will be translated to equivalent SPIR-V target extension types. This translation is only available in the typed pointer mode (-opaque-pointers=0). The relevant LIT tests with SPIR-V builtins were converted to use the new target(...) notation.
michalpaszkowski
force-pushed
the
feature_SPV_INTEL_arbitrary_precision_integers_extension
branch
from
154f0d5 to
021aaf0
Compare
michalpaszkowski
force-pushed
the
feature_SPV_INTEL_arbitrary_precision_integers_extension
branch
from
021aaf0 to
7f30096
Compare
There was a problem hiding this comment.
I am considering extracting generating all instructions relevant to extensions (decorations, capabilities, etc.) out to a separate pass. I will prepare a an experimental pull request.
If it works out, I will consider extracting emitting capabilities also to a separate pass. Then SPIRVModuleAnalysis would truly be "analysis only" pass.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch adds support for the SPV_INTEL_arbitrary_precision_integers extension, enums for new extensions (58-102), and other misc methods for checking extension and capabilities requirements.