[SPIR-V][WIP] Convert LIT tests to opaque pointers #251
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
michalpaszkowski
force-pushed
the
fix_opaque_pointers_mode_tests
branch
from
5e03f03 to
1e89f23
Compare
michalpaszkowski
force-pushed
the
fix_opaque_pointers_mode_tests
branch
from
1e89f23 to
d3f8426
Compare
michalpaszkowski
changed the base branch from
feature/spirv-backend-llvm15_0_7
to
feature/spirv-backend-llvm15_0_7_2
|
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Work in progress to convert all LIT tests to use opaque pointers. Most tests using OpenCL opaque types will be converted to use SPIR-V builtin types via TargetExtType. Some tests explicitly focusing on OpenCL opaque types will be left unchanged with (-opaque-pointers=0).
As part of this patch, I am planning to also reformat and reorganize the tests. Some tests will be merged/split and placed in relevant directories. I think it might be also good to stick to one naming convention for the tests and keep the URL to the source (with the original name) in the comment inside the test.