[SPV-IR] Ignore SPIR-V linkage name for BuiltIn variable #1180
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The BuiltIn variable/call name in SPV-IR should stick to "__spirv_BuiltIn*", no matter what the SPIR-V linkage name is. This is a regression of PR KhronosGroup#1133.
Signed-off-by: Yilong Guo <yilong.guo@intel.com>
|
@AlexeySotkin @AlexeySachkov @Fznamznon @MrSidims @aratajew I'd appreciate if you take a look. |
aratajew
reviewed
Aug 27, 2021
Fznamznon
reviewed
Aug 27, 2021
Fznamznon
approved these changes
Aug 27, 2021
MrSidims
approved these changes
Aug 27, 2021
|
ping |
aratajew
pushed a commit
to aratajew/SPIRV-LLVM-Translator
that referenced
this pull request
Dec 14, 2021
…p#1180) The BuiltIn variable/call name in SPV-IR should stick to "__spirv_BuiltIn*", no matter what the SPIR-V linkage name is. This is a regression of PR KhronosGroup#1133. Signed-off-by: Yilong Guo <yilong.guo@intel.com>
aratajew
pushed a commit
to aratajew/SPIRV-LLVM-Translator
that referenced
this pull request
Dec 14, 2021
…p#1180) The BuiltIn variable/call name in SPV-IR should stick to "__spirv_BuiltIn*", no matter what the SPIR-V linkage name is. This is a regression of PR KhronosGroup#1133. Signed-off-by: Yilong Guo <yilong.guo@intel.com>
aratajew
pushed a commit
to aratajew/SPIRV-LLVM-Translator
that referenced
this pull request
Dec 14, 2021
…p#1180) The BuiltIn variable/call name in SPV-IR should stick to "__spirv_BuiltIn*", no matter what the SPIR-V linkage name is. This is a regression of PR KhronosGroup#1133. Signed-off-by: Yilong Guo <yilong.guo@intel.com>
aratajew
pushed a commit
to aratajew/SPIRV-LLVM-Translator
that referenced
this pull request
Dec 14, 2021
…p#1180) The BuiltIn variable/call name in SPV-IR should stick to "__spirv_BuiltIn*", no matter what the SPIR-V linkage name is. This is a regression of PR KhronosGroup#1133. Signed-off-by: Yilong Guo <yilong.guo@intel.com>
aratajew
pushed a commit
to aratajew/SPIRV-LLVM-Translator
that referenced
this pull request
Dec 14, 2021
…p#1180) The BuiltIn variable/call name in SPV-IR should stick to "__spirv_BuiltIn*", no matter what the SPIR-V linkage name is. This is a regression of PR KhronosGroup#1133. Signed-off-by: Yilong Guo <yilong.guo@intel.com>
aratajew
pushed a commit
to aratajew/SPIRV-LLVM-Translator
that referenced
this pull request
Dec 14, 2021
…p#1180) The BuiltIn variable/call name in SPV-IR should stick to "__spirv_BuiltIn*", no matter what the SPIR-V linkage name is. This is a regression of PR KhronosGroup#1133. Signed-off-by: Yilong Guo <yilong.guo@intel.com>
aratajew
pushed a commit
to aratajew/SPIRV-LLVM-Translator
that referenced
this pull request
Dec 14, 2021
…p#1180) The BuiltIn variable/call name in SPV-IR should stick to "__spirv_BuiltIn*", no matter what the SPIR-V linkage name is. This is a regression of PR KhronosGroup#1133. Signed-off-by: Yilong Guo <yilong.guo@intel.com>
MrSidims
pushed a commit
that referenced
this pull request
Dec 20, 2021
The BuiltIn variable/call name in SPV-IR should stick to "__spirv_BuiltIn*", no matter what the SPIR-V linkage name is. This is a regression of PR #1133. Signed-off-by: Yilong Guo <yilong.guo@intel.com>
MrSidims
pushed a commit
that referenced
this pull request
Dec 20, 2021
The BuiltIn variable/call name in SPV-IR should stick to "__spirv_BuiltIn*", no matter what the SPIR-V linkage name is. This is a regression of PR #1133. Signed-off-by: Yilong Guo <yilong.guo@intel.com>
MrSidims
pushed a commit
that referenced
this pull request
Dec 20, 2021
The BuiltIn variable/call name in SPV-IR should stick to "__spirv_BuiltIn*", no matter what the SPIR-V linkage name is. This is a regression of PR #1133. Signed-off-by: Yilong Guo <yilong.guo@intel.com>
MrSidims
pushed a commit
that referenced
this pull request
Dec 20, 2021
The BuiltIn variable/call name in SPV-IR should stick to "__spirv_BuiltIn*", no matter what the SPIR-V linkage name is. This is a regression of PR #1133. Signed-off-by: Yilong Guo <yilong.guo@intel.com>
MrSidims
pushed a commit
that referenced
this pull request
Dec 20, 2021
The BuiltIn variable/call name in SPV-IR should stick to "__spirv_BuiltIn*", no matter what the SPIR-V linkage name is. This is a regression of PR #1133. Signed-off-by: Yilong Guo <yilong.guo@intel.com>
Quetzonarch
pushed a commit
to Quetzonarch/SPIRV-LLVM-Translator
that referenced
this pull request
Jul 13, 2022
…p#1180) The BuiltIn variable/call name in SPV-IR should stick to "__spirv_BuiltIn*", no matter what the SPIR-V linkage name is. This is a regression of PR KhronosGroup#1133. Signed-off-by: Yilong Guo <yilong.guo@intel.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The BuiltIn variable/call name in SPV-IR should stick to
"__spirv_BuiltIn*", no matter what the SPIR-V linkage name is.
This is an issue exposed by PR #1133.