Fix to not specify the rust toolchain version everywhere #5614
+33
−32
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
QA Wolf here! As you write new code it's important that your test coverage is keeping up. |
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
jtran
force-pushed
the
jtran/fix-rust-toolchain
branch
from
fe39447 to
b0a9133
Compare
jtran
force-pushed
the
jtran/fix-rust-toolchain
branch
from
b0a9133 to
3a6b20e
Compare
jtran
force-pushed
the
jtran/fix-rust-toolchain
branch
from
166153e to
33cf999
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #5614 +/- ##
=======================================
Coverage 86.31% 86.31%
=======================================
Files 102 102
Lines 40294 40294
=======================================
Hits 34778 34778
Misses 5516 5516
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
jtran
force-pushed
the
jtran/fix-rust-toolchain
branch
from
6e2f574 to
54e94c5
Compare
maxammann
approved these changes
Mar 4, 2025
|
@jtran force push |
jtran
force-pushed
the
jtran/fix-rust-toolchain
branch
from
71e49f0 to
54e94c5
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow-up to #5606.
This also fixes
targetdir caching. We weren't specifying the root of our Rust workspace, so ourtargetdirectory was never being cached.Options were removed because after moving to actions-rust-lang/setup-rust-toolchain:
toolchainoption is used, it looks for therust-toolchain.tomlfile.override: trueis the default.defaultoption.Swatinem/rust-cacheis built-in.