Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

implement tournament stub endpoints #10

Merged
merged 7 commits into from
Jun 12, 2019
Merged

Conversation

KnutZuidema
Copy link
Owner

closes #4

@KnutZuidema KnutZuidema self-assigned this Jun 11, 2019
@codecov
Copy link

codecov bot commented Jun 11, 2019

Codecov Report

Merging #10 into master will increase coverage by 6.13%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #10      +/-   ##
==========================================
+ Coverage   93.11%   99.25%   +6.13%     
==========================================
  Files           7        7              
  Lines         465      534      +69     
==========================================
+ Hits          433      530      +97     
+ Misses         22        3      -19     
+ Partials       10        1       -9
Impacted Files Coverage Δ
api/data_dragon.go 100% <100%> (+10.52%) ⬆️
api/riot_api.go 100% <100%> (+5.51%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 501c7cd...dc25b05. Read the comment docs.

@KnutZuidema KnutZuidema force-pushed the tournament_stub_endpoints branch from dc229c4 to 5e57bde Compare June 12, 2019 19:21
@KnutZuidema KnutZuidema marked this pull request as ready for review June 12, 2019 19:22
@KnutZuidema KnutZuidema force-pushed the tournament_stub_endpoints branch 2 times, most recently from 28a5e5d to 75ee3ae Compare June 12, 2019 19:41
@KnutZuidema KnutZuidema force-pushed the tournament_stub_endpoints branch from 75ee3ae to dc25b05 Compare June 12, 2019 21:06
@KnutZuidema KnutZuidema merged commit 6e84409 into master Jun 12, 2019
@KnutZuidema KnutZuidema deleted the tournament_stub_endpoints branch October 14, 2019 05:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Tournament stub endpoints
1 participant