Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: separate riot endpoints by category #31

Merged
merged 5 commits into from
Feb 11, 2020

Conversation

KnutZuidema
Copy link
Owner

resolves #30

@KnutZuidema KnutZuidema self-assigned this Feb 11, 2020
@KnutZuidema KnutZuidema force-pushed the feat/separate_endpoints_by_category_#30 branch from b97060b to a2533a1 Compare February 11, 2020 17:46
@codecov
Copy link

codecov bot commented Feb 11, 2020

Codecov Report

Merging #31 into master will not change coverage.
The diff coverage is 100%.

Impacted file tree graph

@@          Coverage Diff          @@
##           master    #31   +/-   ##
=====================================
  Coverage     100%   100%           
=====================================
  Files           8     17    +9     
  Lines         978    934   -44     
=====================================
- Hits          978    934   -44
Impacted Files Coverage Δ
golio.go 100% <ø> (ø) ⬆️
riot/league.go 100% <100%> (ø)
riot/third_party_code.go 100% <100%> (ø)
riot/tournament.go 100% <100%> (ø)
riot/status.go 100% <100%> (ø)
riot/champion_mastery.go 100% <100%> (ø)
riot/client.go 100% <100%> (ø)
riot/model.go 100% <100%> (ø) ⬆️
riot/summoner.go 100% <100%> (ø)
riot/match.go 100% <100%> (ø)
... and 12 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 56f37b7...fdc8f6a. Read the comment docs.

Verified

This commit was signed with the committer’s verified signature.
KnutZuidema Knut Zuidema

Verified

This commit was signed with the committer’s verified signature.
KnutZuidema Knut Zuidema

Verified

This commit was signed with the committer’s verified signature.
KnutZuidema Knut Zuidema

Verified

This commit was signed with the committer’s verified signature.
KnutZuidema Knut Zuidema

Verified

This commit was signed with the committer’s verified signature.
KnutZuidema Knut Zuidema
@KnutZuidema KnutZuidema force-pushed the feat/separate_endpoints_by_category_#30 branch from a2533a1 to fdc8f6a Compare February 11, 2020 17:53
@KnutZuidema KnutZuidema merged commit deffba3 into master Feb 11, 2020
@KnutZuidema KnutZuidema deleted the feat/separate_endpoints_by_category_#30 branch April 5, 2020 21:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

separate riot api endpoints by category
1 participant