feat(riot/lol): add option parameter to match client List() #38
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
KnutZuidema
reviewed
Jul 25, 2020
Codecov Report
@@ Coverage Diff @@
## master #38 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 21 21
Lines 972 985 +13
=========================================
+ Hits 972 985 +13
Continue to review full report at Codecov.
|
KnutZuidema
approved these changes
Jul 28, 2020
KnutZuidema
requested changes
Jul 28, 2020
KnutZuidema
reviewed
Jul 29, 2020
riot/lol/match.go
Outdated
| param += "&queue=" + strconv.Itoa(queue) | ||
| } | ||
| } | ||
| if mo.BeginTime.IsZero() { |
There was a problem hiding this comment.
Pretty sure you mean this:
Suggested change
| if mo.BeginTime.IsZero() { | |
| if !mo.BeginTime.IsZero() { |
Same below
riot/lol/match_test.go
Outdated
Comment on lines
44
to
45
| BeginTime: time.Time{}, | ||
| EndTime: time.Time{}, |
There was a problem hiding this comment.
Suggested change
| BeginTime: time.Time{}, | |
| EndTime: time.Time{}, | |
| BeginTime: time.Now(), | |
| EndTime: time.Now(), |
We should use actual values here for coverage.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
resolved #37